from PATH
ClosedPublic
Actions

Authored by • jon on Sep 6 2022, 11:00 AM.

Details

Reviewers

varun
atul
• max
• abosh

Commits

rCOMMb7e927be208a: [Nix] Remove /usr/bin/ from PATH

Summary

With https://phab.comm.dev/D5076, pod-patch was updated to not
require BSD sed. This removes the workaround put in place to make that previous
workflow happy.

Depends on D5076

Test Plan

arc patch <this revision>
nix develop

# clean npm, and attempt pod install with new `pod-patch`
yarn cleaninstall
cd native/ios
pod cache clean --all
pod install

open -na xcode
# Comm project should build

Diff Detail

Repository

rCOMM Comm

Branch

jonringer/remove-usr-bin

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 6 2022, 11:00 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 6 2022, 11:00 AM

Harbormaster completed remote builds in B11934: Diff 16385.Sep 6 2022, 11:10 AM

• jon requested review of this revision.Sep 6 2022, 11:10 AM

Rubber stamped! I'm commenting on this line every time to fix the Clang conflict in Nix while using Clang from XCode.

This revision is now accepted and ready to land.Sep 6 2022, 11:19 AM

Exciting!!

• jon mentioned this in D4998: [Services] Update blob to reference new directory.Sep 7 2022, 8:43 AM

Closed by commit rCOMMb7e927be208a: [Nix] Remove /usr/bin/ from PATH (authored by • jon). · Explain WhySep 7 2022, 9:26 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMb7e927be208a: [Nix] Remove /usr/bin/ from PATH.

• jon mentioned this in D5041: [Nix] Fix corrosion usage with nix develop.Sep 7 2022, 9:55 AM

Revision Contents
Changeset List

Path

Size

scripts/

source_development_defaults.sh

2 lines

Diff 16385

View Options

scripts/source_development_defaults.sh

Show First 20 Lines • Show All 193 Lines • ▼ Show 20 Lines	:root {
--spoiler-text-color: var(--spoiler-color);		--spoiler-text-color: var(--spoiler-color);
--spoiler-background-color: var(--spoiler-color);		--spoiler-background-color: var(--spoiler-color);
--purple-link: var(--violet-light-100);		--purple-link: var(--violet-light-100);
--drawer-expand-button: var(--shades-black-60);		--drawer-expand-button: var(--shades-black-60);
--drawer-expand-button-disabled: var(--shades-black-80);		--drawer-expand-button-disabled: var(--shades-black-80);
--drawer-item-color: var(--shades-white-60);		--drawer-item-color: var(--shades-white-60);
--drawer-open-community-bg: #191919;		--drawer-open-community-bg: #191919;
--drawer-bg: var(--shades-black-90);		--drawer-bg: var(--shades-black-90);
		--active-drawer-item: rgba(0, 0, 0, 0.5);
}		}

[Nix] Remove /usr/bin/ from PATHClosedPublicActions