Page MenuHomePhabricator
Differential D5116

[Services] Fix blob test build
ClosedPublic
Actions

Authored by • jon on Sep 12 2022, 1:43 PM.
Tags
None
Referenced Files
F3246710: D5116.diff
Fri, Nov 15, 1:35 AM
Unknown Object (File)
Tue, Nov 12, 1:07 AM
Unknown Object (File)
Sun, Nov 10, 6:32 AM
Unknown Object (File)
Sun, Oct 27, 4:33 AM
Unknown Object (File)
Oct 13 2024, 5:17 AM
Unknown Object (File)
Oct 9 2024, 8:38 PM
Unknown Object (File)
Oct 9 2024, 3:17 AM
Unknown Object (File)
Oct 9 2024, 3:17 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
• abosh
varun
• max
• karol
Commits
rCOMM07375b672901: [Services] Fix blob test build
Summary

I would like to add the test suites to the CI, but they have to
build first

Also, a big change is building the testsuite by default, however, this is
the common practice, and generally people opt-out of building tests by doing
-DBUILD_TESTING=OFF when they invoke cmake.

https://linear.app/comm/issue/ENG-1788

Test Plan
nix develop
cd services/blob
rm -rf build && mkdir build && cd build && cmake .. && make -j
ctest # should fail as AWS needs to be configured, but run

# without tests
nix develop
cd services/blob
rm -rf build && mkdir build && cd build && cmake .. -DBUILD_TESTING=OFF && make -j
ctest # should fail to find tests

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Sep 12 2022, 1:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 12 2022, 1:43 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:45 PM
Harbormaster failed remote builds in B12091: Diff 16598!
• jon updated this revision to Diff 16603.Sep 12 2022, 1:54 PM

Find GTest through cmake config

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 1:54 PM
Harbormaster failed remote builds in B12096: Diff 16603!
• jon added a parent revision: D5121: [Services] Avoid using GTest in docker.Sep 12 2022, 2:04 PM
• jon added a child revision: D5120: [Chore] Cleanup blob CMakeLists.txt.
• jon updated this revision to Diff 16605.Sep 12 2022, 2:05 PM

Rebase on top of docker fixes

Harbormaster completed remote builds in B12098: Diff 16605.Sep 12 2022, 2:13 PM
• jon requested review of this revision.Sep 12 2022, 2:13 PM
atul accepted this revision.Sep 13 2022, 8:55 AM

Was able to successfully follow Test Plan both with and without tests.

This revision is now accepted and ready to land.Sep 13 2022, 8:55 AM
Closed by commit rCOMM07375b672901: [Services] Fix blob test build (authored by • jon). · Explain WhySep 13 2022, 11:45 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM07375b672901: [Services] Fix blob test build.

Revision Contents
Changeset List

PathSize
services/
blob/
41 lines

Diff 16598

View Options

services/blob/CMakeLists.txt

Loading...