Paths

Table of Contentst

Differential D5171

[services] Remove path imports in tests
ClosedPublic
Actions

Authored by michal on Sep 19 2022, 4:06 AM.

Tags

None

Referenced Files

	F1787985: D5171.id16886.diff
	Sat, May 18, 11:55 PM

	Unknown Object (File)
	Wed, May 15, 5:51 PM

	Unknown Object (File)
	Apr 18 2024, 4:48 PM

	Unknown Object (File)
	Apr 18 2024, 4:48 PM

	Unknown Object (File)
	Apr 18 2024, 4:48 PM

	Unknown Object (File)
	Apr 18 2024, 4:47 PM

	Unknown Object (File)
	Apr 18 2024, 4:42 PM

	Unknown Object (File)
	Mar 20 2024, 6:21 AM

View All 45 Files

Subscribers

Details

Reviewers

tomek
varun
• jon
inka

Commits

rCOMM02b91cd13b4f: [services] Remove path imports in tests

Summary

https://linear.app/comm/issue/ENG-1300/[rust]-get-rid-of-import-paths-in-tests
Changes module structure to get rid of #[path=...] attributes. Doesn't change any runtime code, only mod and use statements (and removes a few now unnecessary #[allow(dead_code)]).

Added mod.rs to backup and to blob to make them parent modules of the nested files
Renamed lib/tools.rs to tools/mod.rs to make it a separate module

Test Plan

cargo test --no-run and check if it compiles

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 19 2022, 4:06 AM

Herald added subscribers: • abosh, • karol, atul, ashoat. · View Herald TranscriptSep 19 2022, 4:06 AM

Harbormaster completed remote builds in B12263: Diff 16824.Sep 19 2022, 4:15 AM

michal requested review of this revision.Sep 19 2022, 4:15 AM

otherwise LGTM

services/commtest/tests/backup/add_attachments.rs
1–3 ↗	(On Diff #16824)	Instead of "going up a level", we can also say, "start at the root"

This revision now requires changes to proceed.Sep 19 2022, 11:25 AM

Looks great! Agree with @jon on super vs crate.

Update

Harbormaster completed remote builds in B12299: Diff 16886.Sep 20 2022, 2:32 AM

michal added a child revision: D5189: [services] Move common files from tests to src.Sep 20 2022, 2:59 AM

• jon accepted this revision.Sep 20 2022, 8:18 AM

This revision is now accepted and ready to land.Sep 20 2022, 8:18 AM

Closed by commit rCOMM02b91cd13b4f: [services] Remove path imports in tests (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 21 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM02b91cd13b4f: [services] Remove path imports in tests.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

backup/

add_attachments.rs

14 lines

backup_utils.rs

5 lines

create_new_backup.rs

11 lines

5 lines

16 lines

15 lines

backup_integration_test.rs

23 lines

backup_performance_test.rs

20 lines

blob/

1 line

10 lines

4 lines

11 lines

12 lines

blob_integration_test.rs

16 lines

blob_performance_test.rs

17 lines

lib/

	tools/
	lib/

	mod.rs
	tools.rs

12 lines

tunnelbroker_integration_test.rs

1 line

Diff 16942

services/commtest/tests/backup/add_attachments.rs

Loading...

services/commtest/tests/backup/backup_utils.rs

Loading...

services/commtest/tests/backup/create_new_backup.rs

Loading...

services/commtest/tests/backup/mod.rs

Loading...

services/commtest/tests/backup/pull_backup.rs

Loading...

services/commtest/tests/backup/send_log.rs

Loading...

services/commtest/tests/backup_integration_test.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...

services/commtest/tests/blob/blob_utils.rs

Loading...

services/commtest/tests/blob/get.rs

Loading...

services/commtest/tests/blob/mod.rs

Loading...

services/commtest/tests/blob/put.rs

Loading...

services/commtest/tests/blob/remove.rs

Loading...

services/commtest/tests/blob_integration_test.rs

Loading...

services/commtest/tests/blob_performance_test.rs

Loading...

services/commtest/tests/lib/tools.rs

Loading...

services/commtest/tests/tools/mod.rs

Loading...

services/commtest/tests/tunnelbroker_integration_test.rs

Loading...