Paths

Table of Contentst

[services] Move common files from tests to src
ClosedPublic
Actions

Authored by michal on Sep 20 2022, 2:59 AM.

Details

Reviewers

tomek
varun
• jon
inka

Commits

rCOMM6f291ef93f64: [services] Move common files from tests to src

Summary

As discussed in comments here, this diff moves helper files from tests to src.

Depends on D5171

Test Plan

cargo build and cargo test --no-run and check if it compiles

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Sep 20 2022, 2:59 AM

Herald added subscribers: • abosh, • karol, atul, ashoat. · View Herald TranscriptSep 20 2022, 2:59 AM

Harbormaster completed remote builds in B12302: Diff 16889.Sep 20 2022, 3:07 AM

michal requested review of this revision.Sep 20 2022, 3:07 AM

michal edited the summary of this revision. (Show Details)Sep 20 2022, 3:09 AM

LGTM, builds.

In the future, I would give the directions from the perspective of "I just did arc patch", for example:

cd services/commtest
cargo test --no-run

This revision is now accepted and ready to land.Sep 20 2022, 8:23 AM

Good point, I will try to keep that in mind

michal added 1 blocking reviewer(s): tomek.Sep 21 2022, 1:55 AM

This revision now requires review to proceed.Sep 21 2022, 1:55 AM

tomek accepted this revision.Sep 21 2022, 3:33 AM

This revision is now accepted and ready to land.Sep 21 2022, 3:33 AM

Closed by commit rCOMM6f291ef93f64: [services] Move common files from tests to src (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhySep 21 2022, 3:44 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM6f291ef93f64: [services] Move common files from tests to src.

Revision Contents
Changeset List

Path

Size

services/

commtest/

	src/
	tests/

backup/

blob/

	tools.rs/
	tools/


	mod.rs

2 lines

src/

lib.rs

3 lines

main.rs

tests/

backup/

backup_integration_test.rs

9 lines

backup_performance_test.rs

9 lines

blob/

blob_integration_test.rs

9 lines

blob_performance_test.rs

9 lines

tools/

mod.rs

tunnelbroker_integration_test.rs

2 lines

Diff 16943

View Options

services/commtest/src/backup/add_attachments.rs

View Options

services/commtest/src/backup/backup_utils.rs

View Options

services/commtest/src/backup/create_new_backup.rs

View Options

services/commtest/src/backup/mod.rs

View Options

services/commtest/src/backup/pull_backup.rs

View Options

services/commtest/src/backup/send_log.rs

View Options

services/commtest/src/blob/blob_utils.rs

View Options

services/commtest/src/blob/get.rs

View Options

services/commtest/src/blob/mod.rs

View Options

services/commtest/src/blob/put.rs

View Options

services/commtest/src/blob/remove.rs

View Options

services/commtest/src/lib.rs

View Options

services/commtest/src/main.rs

View Options

services/commtest/src/tools.rs

View Options

services/commtest/tests/backup/add_attachments.rs

View Options

services/commtest/tests/backup/backup_utils.rs

View Options

services/commtest/tests/backup/create_new_backup.rs

View Options

services/commtest/tests/backup/mod.rs

View Options

services/commtest/tests/backup/pull_backup.rs

View Options

services/commtest/tests/backup/send_log.rs

View Options

services/commtest/tests/backup_integration_test.rs

View Options

services/commtest/tests/backup_performance_test.rs

View Options

services/commtest/tests/blob/blob_utils.rs

View Options

services/commtest/tests/blob/get.rs

View Options

services/commtest/tests/blob/mod.rs

View Options

services/commtest/tests/blob/put.rs

View Options

services/commtest/tests/blob/remove.rs

View Options

services/commtest/tests/blob_integration_test.rs

View Options

services/commtest/tests/blob_performance_test.rs

View Options

services/commtest/tests/tools/mod.rs

View Options

services/commtest/tests/tunnelbroker_integration_test.rs

[services] Move common files from tests to srcClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16943

services/commtest/src/backup/add_attachments.rs

services/commtest/src/backup/backup_utils.rs

services/commtest/src/backup/create_new_backup.rs

services/commtest/src/backup/mod.rs

services/commtest/src/backup/pull_backup.rs

services/commtest/src/backup/send_log.rs

services/commtest/src/blob/blob_utils.rs

services/commtest/src/blob/get.rs

services/commtest/src/blob/mod.rs

services/commtest/src/blob/put.rs

services/commtest/src/blob/remove.rs

services/commtest/src/lib.rs

services/commtest/src/main.rs

services/commtest/src/tools.rs

services/commtest/tests/backup/add_attachments.rs

services/commtest/tests/backup/backup_utils.rs

services/commtest/tests/backup/create_new_backup.rs

services/commtest/tests/backup/mod.rs

services/commtest/tests/backup/pull_backup.rs

services/commtest/tests/backup/send_log.rs

services/commtest/tests/backup_integration_test.rs

services/commtest/tests/backup_performance_test.rs

services/commtest/tests/blob/blob_utils.rs

services/commtest/tests/blob/get.rs

services/commtest/tests/blob/mod.rs

services/commtest/tests/blob/put.rs

services/commtest/tests/blob/remove.rs

services/commtest/tests/blob_integration_test.rs

services/commtest/tests/blob_performance_test.rs

services/commtest/tests/tools/mod.rs

services/commtest/tests/tunnelbroker_integration_test.rs

[services] Move common files from tests to src
ClosedPublic
Actions

Revision Contents
Changeset List