[CI] Add `--network-timeout 180000` to `yarn` commands
ClosedPublic
Actions

Authored by atul on Sep 21 2022, 9:01 AM.

Details

Reviewers

ginsu
rohan
marcin
• abosh
varun
• jon
tomek

Commits

rCOMMf467714198b3: [CI] Add `--network-timeout 180000` to `yarn` commands

Summary

The default timeout is 30 seconds. Increasing this to 3 minutes (180*1000) to maybe reduce the number of CI jobs that fail for intermittent network reasons.

Test Plan

Buildkite: Put this diff up
GitHub Actions: Land this diff

Diff Detail

Repository

rCOMM Comm

Branch

increaseTimeout (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Sep 21 2022, 9:01 AM

Herald added a reviewer: • jon. · View Herald TranscriptSep 21 2022, 9:01 AM

Herald added subscribers: tomek, ashoat. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 21 2022, 9:02 AM

Harbormaster failed remote builds in B12349: Diff 16951!

Harbormaster completed remote builds in B12349: Diff 16951.Sep 21 2022, 9:13 AM

atul requested review of this revision.Sep 21 2022, 9:13 AM

I don't know if this will protect against sockets which close (which I think is the underlying issue for most of these failures), but may as well try

This revision is now accepted and ready to land.Sep 21 2022, 9:52 AM

atul added a reviewer: tomek.Sep 21 2022, 10:00 AM

This revision now requires review to proceed.Sep 21 2022, 10:00 AM

In D5204#152715, @jon wrote:

I don't know if this will protect against sockets which close (which I think is the underlying issue for most of these failures), but may as well try

Yeah good point.. also only helps us with yarn and not eg cargo

Going to put up a diff momentarily to do this at the "buildkite level": https://buildkite.com/docs/pipelines/command-step#retry-attributes

atul changed 2 blocking reviewer(s), added 1: varun; removed 1: tomek.Sep 21 2022, 10:36 AM

varun accepted this revision.Sep 21 2022, 12:13 PM

This revision is now accepted and ready to land.Sep 21 2022, 12:13 PM

Closed by commit rCOMMf467714198b3: [CI] Add `--network-timeout 180000` to `yarn` commands (authored by atul). · Explain WhySep 21 2022, 12:50 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMf467714198b3: [CI] Add `--network-timeout 180000` to `yarn` commands.