Page MenuHomePhabricator

[flow] Add `(killall flow || pkill flow || true)` to `cleaninstall`
ClosedPublic

Authored by atul on Sep 23 2022, 8:30 AM.
Tags
None
Referenced Files
F3540781: D5223.diff
Thu, Dec 26, 5:49 AM
Unknown Object (File)
Sun, Dec 15, 9:10 AM
Unknown Object (File)
Sun, Dec 15, 9:10 AM
Unknown Object (File)
Sun, Dec 15, 9:10 AM
Unknown Object (File)
Sun, Dec 15, 9:10 AM
Unknown Object (File)
Sun, Dec 15, 9:05 AM
Unknown Object (File)
Nov 17 2024, 3:26 PM
Unknown Object (File)
Nov 9 2024, 7:39 PM
Subscribers

Details

Summary

When new JS dependencies are added, the flow server(s) need to be restarted to avoid inaccurate errors. In the past it's been on the developer to know this and run killall flow && flow (or the equivalent) to get their dev environment in working condition again. In this diff we just add that to the beginning of cleaninstall to take care of that for us.

killall is for macOS/Darwin (though they do have bsd pkill as well)
pkill is for Ubuntu/Debian/etc
true is for the case where there's no flow server running (eg very first run of yarn cleaninstall)

Test Plan

Ran yarn cleaninstall locally.. the pre-review CI will implicitly test things on Ubuntu/Debian

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2022, 8:41 AM
Harbormaster failed remote builds in B12412: Diff 17031!
atul requested review of this revision.Sep 23 2022, 11:49 AM
atul changed 2 blocking reviewer(s), added 1: varun; removed 1: tomek.Sep 23 2022, 12:22 PM
This revision is now accepted and ready to land.Sep 23 2022, 12:22 PM
This revision was landed with ongoing or failed builds.Sep 23 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.