Paths

Table of Contentst

Differential D5253

[native] created arrow component
ClosedPublic
Actions

Authored by ginsu on Sep 28 2022, 2:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 25, 10:25 PM

	Unknown Object (File)
	Mon, Nov 25, 10:25 PM

	Unknown Object (File)
	Mon, Nov 25, 10:24 PM

	Unknown Object (File)
	Mon, Nov 25, 10:24 PM

	Unknown Object (File)
	Nov 5 2024, 10:01 AM

	Unknown Object (File)
	Nov 5 2024, 10:01 AM

	Unknown Object (File)
	Nov 5 2024, 10:01 AM

	Unknown Object (File)
	Nov 5 2024, 9:58 AM

Subscribers

Details

Reviewers

atul
• abosh
rohan

Commits

rCOMMd2dc86bdf235: [native] created arrow component

Summary

created Arrow component with react-native-svg

Used the React SVGR tool to help build the component with the only modification being that I added the viewBox prop and changed the color from gray to be the original hex value of #808080

Linear task: ENG-1779

Test Plan

Please refer to the screenshot below to see how the arrow looks visually

Screen Shot 2022-09-28 at 5.16.31 PM.png (1×1 px, 676 KB)

To test, use the React SVGR tool and input the following SVG code which is taken from the keyserver repo.

<svg width="27" height="30" viewBox="0 0 27 30" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M1 26H0.5V26.5H1V26ZM26.3536 26.3536C26.5488 26.1583 26.5488 25.8417 26.3536 25.6464L23.1716 22.4645C22.9763 22.2692 22.6597 22.2692 22.4645 22.4645C22.2692 22.6597 22.2692 22.9763 22.4645 23.1716L25.2929 26L22.4645 28.8284C22.2692 29.0237 22.2692 29.3403 22.4645 29.5355C22.6597 29.7308 22.9763 29.7308 23.1716 29.5355L26.3536 26.3536ZM0.5 0V26H1.5V0H0.5ZM1 26.5H26V25.5H1V26.5Z" fill="#808080"/>
</svg>

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 28 2022, 2:20 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 28 2022, 2:20 PM

ginsu edited the summary of this revision. (Show Details)Sep 28 2022, 2:23 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, • abosh, rohan.

ginsu attached a referenced file: F185042: Screen Shot 2022-09-28 at 5.16.31 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)Sep 28 2022, 2:27 PM

ginsu edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B12503: Diff 17160.Sep 28 2022, 2:31 PM

ginsu requested review of this revision.Sep 28 2022, 2:31 PM

atul accepted this revision.Sep 28 2022, 5:20 PM

This revision is now accepted and ready to land.Sep 28 2022, 5:20 PM

I assume that we're going to hold off on landing this until the arrow looks better, yeah?

@ashoat yes I will create a follow-up diff where the arrows are aligned to the thread and everything looks clean

ginsu added a child revision: D5268: [native] added arrows for threads in chat inbox.Sep 29 2022, 2:20 PM

Closed by commit rCOMMd2dc86bdf235: [native] created arrow component (authored by ginsu). · Explain WhyOct 3 2022, 2:19 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMd2dc86bdf235: [native] created arrow component.

Revision Contents
Changeset List

Path

Size

native/

components/

23 lines

Diff 17306

native/components/arrow.react.js

Loading...