Page MenuHomePhabricator

[services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app
ClosedPublic

Authored by max on Oct 20 2022, 7:40 AM.
Tags
None
Referenced Files
F2186987: D5435.id18120.diff
Thu, Jul 4, 5:20 AM
Unknown Object (File)
Sun, Jun 30, 7:28 AM
Unknown Object (File)
Sat, Jun 29, 10:55 AM
Unknown Object (File)
Thu, Jun 27, 10:07 PM
Unknown Object (File)
Thu, Jun 27, 2:49 PM
Unknown Object (File)
Thu, Jun 27, 12:57 PM
Unknown Object (File)
Wed, Jun 26, 4:03 PM
Unknown Object (File)
Wed, Jun 26, 10:00 AM

Details

Summary

This diff is a part of the flat diffs stack to transform the current Tunnelbroker project into a Rust app by calling the current C++ codebase from Rust. The related transition task is ENG-1072.

This diff makes changes to the global .gitignore file to remove the old build cache directory, append an updated one, and remove the unused anymore config file from the ignore list.

The project directory structure task and discussion: ENG-2083

CI Notice:
The CI will fail on this and further diffs until the D5461 where the changes to CI build commands are made.
This stack will be landed all in one to prevent CI from failing on diffs out of this stack.

Test Plan

1. CI Testing:
These diff changes are included as a part of the stack in the later D5461 diff, where the changes to CI build commands are made. The CI succeded on the D5461 which reflects that this changes are passing the build.

2. Manually testing:
These diff changes can be tested in the middle of the stack at D5436. To test it patch to D5436 using arc patch D5436, run nix develop. Go to tunnelbroker service directory services/tunnelbroker and run the Cargo building process cargo build or cargo run.
The Rust application will be successfully built.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max added reviewers: jon, varun, marcin.
max published this revision for review.Oct 20 2022, 8:21 AM
This revision is now accepted and ready to land.Oct 21 2022, 9:00 AM
This revision now requires review to proceed.Oct 21 2022, 9:12 AM
This revision is now accepted and ready to land.Oct 21 2022, 10:19 AM

Updating on the stack reordering.
Adding of services/tunnelbroker/src/libcpp/test/build directory to ignore the C++ gTest building cache.

This revision is now accepted and ready to land.Oct 24 2022, 3:35 AM
max edited the test plan for this revision. (Show Details)
max added 1 blocking reviewer(s): ashoat.

Updating on a stack changes.

I've added services/tunnelbroker/src/libcpp/test/build directory to ignore the C++ gTest building cache.
We are building and running gTests for a legacy C++ codebase in Buildkite as well in D5461.
Will re-request a review from @ashoat.

This revision is now accepted and ready to land.Oct 24 2022, 10:21 AM

Rebasing on master changes.

This revision was landed with ongoing or failed builds.Nov 7 2022, 6:09 AM
This revision was automatically updated to reflect the committed changes.