Details

Reviewers

• jon
varun
marcin
tomek
ashoat

Commits

rCOMM3fb5533c5d5d: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust…

Summary

This diff is a part of the flat diffs stack to transform the current Tunnelbroker project into a Rust app by calling the current C++ codebase from Rust. The related transition task is ENG-1072.

This diff creates the Cargo project file for the Tunnelbroker application and its dependencies.

Related Linear task: ENG-2061

Dependencies description:
cxx - Needed for the C++ and Rust interop.
cxx-build - Building C++ codebase.
glob - Used in the helper function to traverse the directory for .cpp files (used in D5434).
tracing - We will use it for logging in threads.
log - Logging.
env_logger - Getting log level from env variable.
tokio - Asynchronous runtime needed for Tokio and our threads.
lazy_static - Lazy static initialization.
a2 - Notification library dependency.
fcm - Notification library dependency.
anyhow - Trait object-based error type for easy idiomatic error handling, that is used in the Notification library.
openssl - Notification library dependency.
tonic - gRPC server dependency (used in D5477).
tonic-build - Compiling the proto file (used in D5360).
prost - Tonic dependency (used in D5477).
prost-types - gRPC well-known types dependency (used in D5477).
futures - Used for handling stream in Tonic (used in D5477).

CI Notice:
The CI will fail on these diffs until the D5461 with the changes to CI build commands.
This stack will be landed all in one to prevent CI from failing on diffs out of this stack.

Test Plan

Run nix develop from the root of the repo.
Go to tunnelbroker service directory services/tunnelbroker and run the Cargo building process cargo build or cargo run.
The Rust application will be successfully built.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Oct 20 2022, 7:42 AM

• max held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 7:42 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald Transcript

• max added a parent revision: D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.Oct 20 2022, 7:42 AM

Harbormaster failed remote builds in B12929: Diff 17720!Oct 20 2022, 7:46 AM

• max mentioned this in D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.Oct 20 2022, 7:55 AM

• max mentioned this in D5429: [services] Tunnelbroker - Initialization function exposed to Rust.Oct 20 2022, 8:00 AM

• max mentioned this in D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.Oct 20 2022, 8:04 AM

• max mentioned this in D5431: [services] Tunnelbroker - Removing of deprecated C++ files.

• max mentioned this in D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.Oct 20 2022, 8:09 AM

• max mentioned this in D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.Oct 20 2022, 8:11 AM

• max mentioned this in D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.Oct 20 2022, 8:13 AM

• max edited the summary of this revision. (Show Details)Oct 20 2022, 8:18 AM

• max edited the test plan for this revision. (Show Details)

• max added reviewers: varun, marcin. • max added 1 blocking reviewer(s): • jon.

• max published this revision for review.Oct 20 2022, 8:27 AM

Adding of prost and futures.

Harbormaster failed remote builds in B12967: Diff 17810!Oct 21 2022, 8:53 AM

• max edited the summary of this revision. (Show Details)Oct 21 2022, 9:00 AM

• max added a child revision: D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.Oct 21 2022, 12:02 PM

Updating on a stack reordering.

Harbormaster failed remote builds in B12986: Diff 17844!Oct 24 2022, 3:39 AM

• max edited the summary of this revision. (Show Details)Oct 24 2022, 9:36 AM

• max edited the test plan for this revision. (Show Details)

Update on a stack changes.

Harbormaster failed remote builds in B13009: Diff 17868!Oct 24 2022, 9:38 AM

• max edited the summary of this revision. (Show Details)Oct 26 2022, 2:48 AM

accepting since the builds are corrected later on.

This revision is now accepted and ready to land.Oct 26 2022, 2:01 PM

• max added a reviewer: tomek.Oct 27 2022, 2:31 AM

This revision now requires review to proceed.Oct 27 2022, 2:31 AM

tomek accepted this revision.Oct 27 2022, 4:56 AM

tomek added a reviewer: ashoat.

tomek added inline comments.

services/tunnelbroker/Cargo.toml
13 ↗	(On Diff #17868)	Versions of this lib seem to be inconsistent through the codebase. Also, the most recent version is `1.21` - is there a reason for adding a dependency to older version?

Updating Tokio to 1.21 version.

Harbormaster failed remote builds in B13080: Diff 17957!Oct 27 2022, 9:01 AM

• max marked an inline comment as done.Oct 27 2022, 9:02 AM

• max added inline comments.

services/tunnelbroker/Cargo.toml
13 ↗	(On Diff #17868)	Versions of this lib seem to be inconsistent through the codebase. Also, the most recent version is `1.21` - is there a reason for adding a dependency to older version? No reason to use the old version, it just came from the current version in the Tunnelbroker. I've updated it to the recent `1.21`. Also, I've checked all the dependencies to make sure they are on the latest versions. Thanks for the catch @tomek !