Details

Reviewers

• jon
varun
marcin
tomek

Commits

rCOMM3bc6ae7304d1: [services] Tunnelbroker - Changing Buildkite commands for Tunnelbroker to run…

Summary

This diff introduces changes to the Buildkite to change the build commands for Tunnelbroker from cmake to use cargo build and cargo test instead. We are removing the target directory before building to remove the cache.
Also, the building and running of the tests for the legacy C++ code are added.

Related Linear task: ENG-2062

Test Plan

To test manually, we can run the Buildkite commands in the root of the repo to ensure they are successful.

Running the following commands in a repo root directory will be expected to succeed:

cd services/tunnelbroker
rm -rf target
nix develop --accept-flake-config -c bash -c "cargo build && cargo test"
cd src/libcpp/test
rm -rf build
nix develop --accept-flake-config -c bash -c "cmake -B build . && make -C build -j"
build/bin/runTests --gtest_filter="-AmqpManager*:DatabaseManager*"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Oct 21 2022, 3:11 PM

• max held this revision as a draft.

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 21 2022, 3:11 PM

• max added a parent revision: D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.Oct 21 2022, 3:12 PM

• max published this revision for review.Oct 21 2022, 3:18 PM

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, varun, marcin.

Harbormaster completed remote builds in B12980: Diff 17830.Oct 21 2022, 3:21 PM

• max planned changes to this revision.Oct 24 2022, 3:52 AM

• max mentioned this in D5428: [services] Tunnelbroker - Moving directories according to the Rust app structure.Oct 24 2022, 9:19 AM

• max mentioned this in D5429: [services] Tunnelbroker - Initialization function exposed to Rust.Oct 24 2022, 9:21 AM

• max mentioned this in D5431: [services] Tunnelbroker - Removing of deprecated C++ files.

• max mentioned this in D5430: [services] Tunnelbroker - Moving CMakeLists file to use for gTest only.Oct 24 2022, 9:26 AM

• max mentioned this in D5432: [services] Tunnelbroker - Creating `main.rs` entry point file for Rust.

• max mentioned this in D5434: [services] Tunnelbroker - Creating `build.rs` file for building and linking C++ dependencies.Oct 24 2022, 9:30 AM

• max mentioned this in D5435: [services] Tunnelbroker - Updating `.gitignore` on the Tunnelbroker transition to Rust app.

• max mentioned this in D5436: [services] Tunnelbroker - Creating Cargo config file for Tunnelbroker as a Rust app.Oct 24 2022, 9:36 AM

Adding of the gTest building and running for the legacy C++ code.

• max mentioned this in D5458: [services] Tunnelbroker - Changes to build the Tunnelbroker using `cargo` in a Docker.Oct 24 2022, 9:44 AM

• max edited the summary of this revision. (Show Details)Oct 24 2022, 9:48 AM

• max edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13011: Diff 17870.Oct 24 2022, 9:50 AM

• max added a child revision: D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.Oct 24 2022, 10:14 AM

• max mentioned this in D5360: [services] Tunnelbroker - Add protobuf file compilation to Cargo `build.rs`.Oct 24 2022, 10:17 AM

LGTM

This revision is now accepted and ready to land.Oct 26 2022, 2:06 PM

• max added a reviewer: tomek.Oct 27 2022, 2:31 AM

This revision now requires review to proceed.Oct 27 2022, 2:31 AM

tomek accepted this revision.Oct 27 2022, 5:01 AM

tomek added inline comments.

.buildkite/tunnelbroker_unittests.yml
10 ↗	(On Diff #17870)	Can we be less specific while filtering the tests? Currently, if we want to introduce a new test, we would need to update this specification.

This revision is now accepted and ready to land.Oct 27 2022, 5:01 AM

• max marked an inline comment as done.Nov 2 2022, 9:40 AM

• max added inline comments.

.buildkite/tunnelbroker_unittests.yml
10 ↗	(On Diff #17870)	Can we be less specific while filtering the tests? Currently, if we want to introduce a new test, we would need to update this specification. We are filtering the tests that require running a localstack and rabbitmq to pass that's why we are filtering them here. The C++ codebase for the Tunnelbroker is frozen now and we are switching to using Rust, I assume that the new updates will be in the Rust codebase. That's why this is highly unlikely that we will introduce some new tests for these filtered patterns.