Details
Please watch the video demo to see that there are no visaul or performance regressions:
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/chat/text-message.react.js | ||
|---|---|---|
| 124–125 ↗ | (On Diff #17793) | removed this if condition because this.props.canCreateSidebarFromMessage will always be true for all messages, while this.props.item.threadCreatedFromMessage will not always be true |
| native/navigation/tooltip.react.js | ||
| 132–133 ↗ | (On Diff #17793) | we need to keep these conditions because MultimediaMessageTooltipModal and RobotextMessageTooltipModal still use create_sidebar and open_sidebar |
| native/navigation/tooltip.react.js | ||
|---|---|---|
| 132–133 ↗ | (On Diff #17793) | Do they need to? Why don't we dedup for them too? |
| native/navigation/tooltip.react.js | ||
|---|---|---|
| 132–133 ↗ | (On Diff #17793) | okay i can do that! |
| native/chat/multimedia-message.react.js | ||
|---|---|---|
| 85–87 | removed this if condition because this.props.canCreateSidebarFromMessage will always be true for all messages, while this.props.item.threadCreatedFromMessage will not always be true | |
Don't think the following assumption is correct:
removed this if condition because this.props.canCreateSidebarFromMessage will always be true for all messages, while this.props.item.threadCreatedFromMessage will not always be true
| native/chat/multimedia-message.react.js | ||
|---|---|---|
| 85–87 |
Ah this isn't always true. For example if you go to one of the sidebars in Daily Updates you'll see that you can't create a sidebar from those messages. We probably want something like: if (this.props.item.threadCreatedFromMessage || this.props.canCreateSidebarFromMessage) { result.push('sidebar'); } ? Let me know if I'm missing something here!\ | |