Page MenuHomePhabricator
Differential D5586

[lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted`
ClosedPublic
Actions

Authored by atul on Nov 9 2022, 12:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Mon, Nov 4, 12:03 AM
Unknown Object (File)
Mon, Nov 4, 12:03 AM
Unknown Object (File)
Mon, Nov 4, 12:03 AM
Unknown Object (File)
Sun, Nov 3, 11:58 PM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
Unknown Object (File)
Sat, Nov 2, 9:57 PM
View All 71 Files
Subscribers
• abosh
ashoat

Details

Reviewers
tomek
varun
marcin
rohan
ginsu
ashoat
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMc04a2c91c1a8: [lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted`
Summary

Specifically to properly redact payload of SET_MESSAGE_STORE_MESSAGES action type.

Added:

  • thread
  • content
  • user
  • uri
  • extras
  • local_id
Test Plan
  1. Trigger a crash after SET_MESSAGE_STORE_MESSAGES
  2. Download crash report
  3. Check SET_MESSAGE_STORE_MESSAGES payload to make sure things are properly redacted

4d8580.png (1×978 px, 334 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D5586 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Nov 9 2022, 12:18 PM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 9 2022, 12:18 PM
Harbormaster completed remote builds in B13340: Diff 18292.Nov 9 2022, 12:29 PM
atul requested review of this revision.Nov 9 2022, 12:29 PM
atul added a reviewer: Restricted Owners Package.Nov 10 2022, 5:53 AM
ashoat accepted this revision.Nov 10 2022, 1:25 PM
This revision is now accepted and ready to land.Nov 10 2022, 1:25 PM
atul updated this revision to Diff 18350.Nov 10 2022, 1:38 PM

rebase before landing

atul added a comment.Nov 10 2022, 1:48 PM

(Haven't done this yet, about to)

Tested before landing:

4d8580.png (1×978 px, 334 KB)

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 1:49 PM
This revision was landed with ongoing or failed builds.Nov 10 2022, 1:50 PM
Closed by commit rCOMMc04a2c91c1a8: [lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc04a2c91c1a8: [lib] Add keys to `sanitization.js:keysWithStringsToBeRedacted`.
Harbormaster completed remote builds in B13381: Diff 18350.Nov 10 2022, 1:52 PM

Revision Contents
Changeset List

PathSize
lib/
utils/
6 lines

Diff 18350

View Options

lib/utils/sanitization.js

Loading...