[keyserver] Stop returning set of `deviceToken`s in `rescindPushNotifs(...)`
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 1:34 PM.

Details

Reviewers

tomek
marcin
varun
ginsu
rohan
ashoat

Commits

rCOMM4c5277d8ef9c: [keyserver] Stop returning set of `deviceToken`s in `rescindPushNotifs(...)`

Summary

We were previously using the set of deviceTokens returned by rescindPushNotifs(...) in rescindAndUpdateBadgeCounts to skip updateBadgeCount(...) for devices that had notifications rescinded. See D5606 for context.

Basically, we don't need the set of deviceTokens in rescindAndUpdateBadgeCounts and it isn't used anywhere else so it can be removed.

Depends on D5606

Test Plan

Looked at other usages of rescindPushNotifs(...) and the return value was never used:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 10 2022, 1:34 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 10 2022, 1:34 PM

atul published this revision for review.Nov 10 2022, 1:34 PM

atul edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13380: Diff 18349.Nov 10 2022, 1:44 PM

Probably should put this in a stack with the other diff on Phabricator, so it's clear to reviewers that it won't break anything

This revision is now accepted and ready to land.Nov 10 2022, 1:44 PM

In D5607#166214, @ashoat wrote:

Probably should put this in a stack with the other diff on Phabricator, so it's clear to reviewers that it won't break anything

Ah yeah good point sorry, just updated summary

atul edited the summary of this revision. (Show Details)Nov 10 2022, 1:48 PM

atul added a parent revision: D5606: [native] Don't skip `updateBadgeCount` for `deviceTokens` handled by `rescindPushNotifs`.

Closed by commit rCOMM4c5277d8ef9c: [keyserver] Stop returning set of `deviceToken`s in `rescindPushNotifs(...)` (authored by atul). · Explain WhyNov 10 2022, 1:53 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4c5277d8ef9c: [keyserver] Stop returning set of `deviceToken`s in `rescindPushNotifs(...)`.