Paths

Table of Contentst

[native] Fix appearance of Inbox header in light mode
ClosedPublic
Actions

Authored by atul on Nov 10 2022, 5:11 PM.

Details

Reviewers

tomek
marcin
ginsu
rohan
• abosh
varun
ashoat

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rCOMM10d59f3d5dbb: [native] Fix appearance of Inbox header in light mode

Summary

Context: https://linear.app/comm/issue/ENG-1395/inbox-header-remains-dark-in-light-mode
https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

The backgroundColor of the Inbox header was previously hardcoded to a dark value that looked fine in dark mode but looked broken in light mode.

This diff sets the backgroundColor to tabBarBackground which will adapt based on the theme.

Test Plan

Before:

After:

Things looks as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 10 2022, 5:11 PM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 10 2022, 5:11 PM

atul edited the test plan for this revision. (Show Details)Nov 10 2022, 5:12 PM

Harbormaster completed remote builds in B13385: Diff 18360.Nov 10 2022, 5:25 PM

atul requested review of this revision.Nov 10 2022, 5:25 PM

rohan accepted this revision.Nov 10 2022, 9:26 PM

This revision is now accepted and ready to land.Nov 10 2022, 9:26 PM

atul added a reviewer: Restricted Owners Package.Nov 10 2022, 9:28 PM

This revision now requires review to proceed.Nov 10 2022, 9:28 PM

ginsu accepted this revision.Nov 11 2022, 9:12 AM

ashoat accepted this revision.Nov 11 2022, 1:04 PM

This revision is now accepted and ready to land.Nov 11 2022, 1:04 PM

Closed by commit rCOMM10d59f3d5dbb: [native] Fix appearance of Inbox header in light mode (authored by atul). · Explain WhyNov 11 2022, 1:09 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM10d59f3d5dbb: [native] Fix appearance of Inbox header in light mode.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat.react.js

25 lines

Diff 18360

View Options

[native] Fix appearance of Inbox header in light modeClosedPublicActions