Page MenuHomePhabricator
Differential D5649

Persist drafts in SQLite
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 27, 2:01 AM
Unknown Object (File)
Fri, Mar 21, 9:57 PM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 10:05 AM
Unknown Object (File)
Sun, Mar 16, 9:54 AM
Unknown Object (File)
Sun, Mar 16, 9:42 AM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
atul
tomek
Commits
rCOMMee59fc68892d: Persist drafts in SQLite
Summary

This differential uses new CommCoreModule functionality to persist drafts in SQLite database.

Test Plan

At this point a potential test would involve dispatching appriproate redux action and examine flipper and SQLite.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2137
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 16 2022, 5:21 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 5:21 AM
marcin added a parent revision: D5648: Implement draft store operations processing in CommCoreModule.Nov 16 2022, 5:22 AM
marcin added a child revision: D5650: Remove CoreData and CoreDataProvider and use draftStore instead.Nov 16 2022, 5:26 AM
Harbormaster completed remote builds in B13475: Diff 18474.Nov 16 2022, 5:34 AM
marcin requested review of this revision.Nov 16 2022, 5:34 AM
marcin planned changes to this revision.Nov 17 2022, 2:58 AM
marcin requested review of this revision.Nov 17 2022, 8:23 AM
atul accepted this revision.Nov 17 2022, 3:24 PM

Looks good, the way you've broken down the diffs in this stack have made things super clear/easy to review!

This revision is now accepted and ready to land.Nov 17 2022, 3:24 PM
tomek accepted this revision.Nov 18 2022, 4:02 AM
marcin updated this revision to Diff 18690.Nov 21 2022, 9:40 AM

Rebase master

Harbormaster completed remote builds in B13643: Diff 18690.Nov 21 2022, 9:54 AM
marcin updated this revision to Diff 18759.Nov 23 2022, 4:56 AM

Rebase before landing

Harbormaster completed remote builds in B13693: Diff 18759.Nov 23 2022, 5:09 AM
Closed by commit rCOMMee59fc68892d: Persist drafts in SQLite (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMee59fc68892d: Persist drafts in SQLite.

Revision Contents
Changeset List

PathSize
native/
redux/
11 lines

Diff 18474

View Options

native/redux/redux-setup.js

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,652 Lines • ▼ Show 20 Lines
combined-stream@^1.0.8: combined-stream@^1.0.8:
version "1.0.8" version "1.0.8"
resolved "https://registry.yarnpkg.com/combined-stream/-/combined-stream-1.0.8.tgz#c3d45a8b34fd730631a110a8a2520682b31d5a7f" resolved "https://registry.yarnpkg.com/combined-stream/-/combined-stream-1.0.8.tgz#c3d45a8b34fd730631a110a8a2520682b31d5a7f"
integrity sha512-FQN4MRfuJeHf7cBbBMJFXhKSDq+2kAArBlmRBvcvFE5BB1HZKXtSFASDhdlz9zOYwxh8lDdnvmMOe/+5cdoEdg== integrity sha512-FQN4MRfuJeHf7cBbBMJFXhKSDq+2kAArBlmRBvcvFE5BB1HZKXtSFASDhdlz9zOYwxh8lDdnvmMOe/+5cdoEdg==
dependencies: dependencies:
delayed-stream "~1.0.0" delayed-stream "~1.0.0"
"comm-react-native-codegen@npm:react-native-codegen@^0.70.6", react-native-codegen@^0.70.6:
version "0.70.6"
resolved "https://registry.yarnpkg.com/react-native-codegen/-/react-native-codegen-0.70.6.tgz#2ce17d1faad02ad4562345f8ee7cbe6397eda5cb"
integrity sha512-kdwIhH2hi+cFnG5Nb8Ji2JwmcCxnaOOo9440ov7XDzSvGfmUStnCzl+MCW8jLjqHcE4icT7N9y+xx4f50vfBTw==
dependencies:
"@babel/parser" "^7.14.0"
flow-parser "^0.121.0"
jscodeshift "^0.13.1"
nullthrows "^1.1.1"
command-exists@^1.2.4: command-exists@^1.2.4:
version "1.2.9" version "1.2.9"
resolved "https://registry.yarnpkg.com/command-exists/-/command-exists-1.2.9.tgz#c50725af3808c8ab0260fd60b01fbfa25b954f69" resolved "https://registry.yarnpkg.com/command-exists/-/command-exists-1.2.9.tgz#c50725af3808c8ab0260fd60b01fbfa25b954f69"
integrity sha512-LTQ/SGc+s0Xc0Fu5WaKnR0YiygZkm9eKFvyS+fRsU7/ZWFF8ykFM6Pc9aCVf1+xasOOZpO3BAVgVrKvsqKHV7w== integrity sha512-LTQ/SGc+s0Xc0Fu5WaKnR0YiygZkm9eKFvyS+fRsU7/ZWFF8ykFM6Pc9aCVf1+xasOOZpO3BAVgVrKvsqKHV7w==
command-exists@^1.2.8: command-exists@^1.2.8:
version "1.2.8" version "1.2.8"
resolved "https://registry.yarnpkg.com/command-exists/-/command-exists-1.2.8.tgz#715acefdd1223b9c9b37110a149c6392c2852291" resolved "https://registry.yarnpkg.com/command-exists/-/command-exists-1.2.8.tgz#715acefdd1223b9c9b37110a149c6392c2852291"
▲ Show 20 Lines • Show All 10,236 Lines • ▼ Show 20 Lines
react-native-camera@^3.31.0: react-native-camera@^3.31.0:
version "3.31.0" version "3.31.0"
resolved "https://registry.yarnpkg.com/react-native-camera/-/react-native-camera-3.31.0.tgz#7b9b4dd30b6d1363bdffed4ce0a0bef93c3ebf87" resolved "https://registry.yarnpkg.com/react-native-camera/-/react-native-camera-3.31.0.tgz#7b9b4dd30b6d1363bdffed4ce0a0bef93c3ebf87"
integrity sha512-TTuse7JGVUbh/cj+a4OfyXoPqhwPyYx+63tzJWZT0sWwZX5bvlxjYaEur/U1hiZZjOC03muEIMkTD7nYp6ZVFA== integrity sha512-TTuse7JGVUbh/cj+a4OfyXoPqhwPyYx+63tzJWZT0sWwZX5bvlxjYaEur/U1hiZZjOC03muEIMkTD7nYp6ZVFA==
dependencies: dependencies:
prop-types "^15.6.2" prop-types "^15.6.2"
react-native-codegen@^0.70.6:
version "0.70.6"
resolved "https://registry.yarnpkg.com/react-native-codegen/-/react-native-codegen-0.70.6.tgz#2ce17d1faad02ad4562345f8ee7cbe6397eda5cb"
integrity sha512-kdwIhH2hi+cFnG5Nb8Ji2JwmcCxnaOOo9440ov7XDzSvGfmUStnCzl+MCW8jLjqHcE4icT7N9y+xx4f50vfBTw==
dependencies:
"@babel/parser" "^7.14.0"
flow-parser "^0.121.0"
jscodeshift "^0.13.1"
nullthrows "^1.1.1"
react-native-device-info@^8.0.7: react-native-device-info@^8.0.7:
version "8.0.7" version "8.0.7"
resolved "https://registry.yarnpkg.com/react-native-device-info/-/react-native-device-info-8.0.7.tgz#c04f5dd50a977da21305b99088c0b42b588d07f9" resolved "https://registry.yarnpkg.com/react-native-device-info/-/react-native-device-info-8.0.7.tgz#c04f5dd50a977da21305b99088c0b42b588d07f9"
integrity sha512-CSGosqvESXWKTfYa+6gYd3HRQOkJm6C+TSXfaipat4Q0BzUHWWNaS5M5z7x72hg6FRk25rJ4zxSmSCQvizHzzQ== integrity sha512-CSGosqvESXWKTfYa+6gYd3HRQOkJm6C+TSXfaipat4Q0BzUHWWNaS5M5z7x72hg6FRk25rJ4zxSmSCQvizHzzQ==
react-native-exit-app@^1.1.0: react-native-exit-app@^1.1.0:
version "1.1.0" version "1.1.0"
resolved "https://registry.yarnpkg.com/react-native-exit-app/-/react-native-exit-app-1.1.0.tgz#5ec082152974240e2d6a93f1608efb49a4385f21" resolved "https://registry.yarnpkg.com/react-native-exit-app/-/react-native-exit-app-1.1.0.tgz#5ec082152974240e2d6a93f1608efb49a4385f21"
▲ Show 20 Lines • Show All 4,591 Lines • Show Last 20 Lines