Page MenuHomePhabricator
Differential D5649

Persist drafts in SQLite
ClosedPublic
Actions

Authored by marcin on Nov 16 2022, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 5:49 PM
Unknown Object (File)
Sun, Nov 24, 3:50 PM
Unknown Object (File)
Sun, Nov 24, 3:39 PM
Unknown Object (File)
Sun, Nov 24, 1:46 PM
Unknown Object (File)
Tue, Nov 19, 2:23 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
Unknown Object (File)
Tue, Nov 19, 2:22 PM
View All Files
Subscribers
• abosh
ashoat

Details

Reviewers
atul
tomek
Commits
rCOMMee59fc68892d: Persist drafts in SQLite
Summary

This differential uses new CommCoreModule functionality to persist drafts in SQLite database.

Test Plan

At this point a potential test would involve dispatching appriproate redux action and examine flipper and SQLite.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Nov 16 2022, 5:21 AM
Herald added subscribers: • abosh, ashoat. · View Herald TranscriptNov 16 2022, 5:21 AM
marcin added a parent revision: D5648: Implement draft store operations processing in CommCoreModule.Nov 16 2022, 5:22 AM
marcin added a child revision: D5650: Remove CoreData and CoreDataProvider and use draftStore instead.Nov 16 2022, 5:26 AM
Harbormaster completed remote builds in B13475: Diff 18474.Nov 16 2022, 5:34 AM
marcin requested review of this revision.Nov 16 2022, 5:34 AM
marcin planned changes to this revision.Nov 17 2022, 2:58 AM
marcin requested review of this revision.Nov 17 2022, 8:23 AM
atul accepted this revision.Nov 17 2022, 3:24 PM

Looks good, the way you've broken down the diffs in this stack have made things super clear/easy to review!

This revision is now accepted and ready to land.Nov 17 2022, 3:24 PM
tomek accepted this revision.Nov 18 2022, 4:02 AM
marcin updated this revision to Diff 18690.Nov 21 2022, 9:40 AM

Rebase master

Harbormaster completed remote builds in B13643: Diff 18690.Nov 21 2022, 9:54 AM
marcin updated this revision to Diff 18759.Nov 23 2022, 4:56 AM

Rebase before landing

Harbormaster completed remote builds in B13693: Diff 18759.Nov 23 2022, 5:09 AM
Closed by commit rCOMMee59fc68892d: Persist drafts in SQLite (authored by marcin). · Explain WhyNov 23 2022, 5:51 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMee59fc68892d: Persist drafts in SQLite.

Revision Contents
Changeset List

PathSize
native/
redux/
11 lines

Diff 18767

View Options

native/redux/redux-setup.js

Loading...