Boilerplate for proto interface. The server listens on 50051 port,
this is the default in current C++ implementation for all services. In subsequent diffs
I'll add possibility to configure this.
Depends on D5676
Details
Details
Run the service. Client should be able to send requests, server should send
"unimplemented" error messages to client.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Does Phabricator require me to re-request reviews every time I reply to comments?
| services/blob/src/main.rs | ||
|---|---|---|
| 14 ↗ | (On Diff #18579) | I'm planning to do it later - There's a Linear task for that: https://linear.app/comm/issue/ENG-2308/improve-logging-in-blob-service |
| services/blob/src/service.rs | ||
| 2 ↗ | (On Diff #18579) | It is generated from proto. |
| 23 ↗ | (On Diff #18579) | Doing it this way allowed me to test if responses are sent to the client. |
Comment Actions
If the revision shows up as "Needs Revision", that means it's on your queue on not on your reviewers' queue. If you update the diff you'll see that the status switches. Simply adding a comment will not switch the status, so yes you will need to re-request review if you don't think any of your reviewers' comments need to be addressed. This scenario should ideally be rare