Page MenuHomePhabricator
Differential D5681

[services][blob] Introduce database client
ClosedPublic
Actions

Authored by bartek on Nov 18 2022, 10:19 AM.
Tags
None
Referenced Files
F3504837: D5681.diff
Fri, Dec 20, 10:45 AM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:50 PM
Unknown Object (File)
Sun, Dec 15, 5:49 PM
Unknown Object (File)
Sun, Dec 15, 5:29 PM
Unknown Object (File)
Tue, Dec 3, 10:08 AM
Unknown Object (File)
Thu, Nov 28, 9:46 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
tomek
marcin
Commits
rCOMM7790e0898b88: [services][blob] Introduce database client
Summary

Introduced DynamoDB database client - the same way as it is implemented in Identity Service.

The interface of the C++ implementation is here.

Depends on D5680

Test Plan

Only ensured that build does not fail.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/blob-rust
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bartek created this revision.Nov 18 2022, 10:19 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptNov 18 2022, 10:19 AM
Harbormaster completed remote builds in B13572: Diff 18591.Nov 18 2022, 10:33 AM
bartek added a child revision: D5682: [services][blob] Provide S3 and DB to service, add more constants.Nov 18 2022, 10:35 AM
bartek published this revision for review.Nov 18 2022, 10:44 AM
bartek edited the summary of this revision. (Show Details)
ashoat added 1 blocking reviewer(s): varun.Nov 18 2022, 12:59 PM
varun accepted this revision.Nov 22 2022, 9:53 AM
This revision is now accepted and ready to land.Nov 22 2022, 9:53 AM
tomek accepted this revision.Nov 23 2022, 1:33 AM
tomek added inline comments.Nov 23 2022, 1:53 AM
services/blob/src/database.rs
33

Shouldn't we use anyhow Result?

bartek updated this revision to Diff 18803.Nov 24 2022, 12:45 AM

Rebase, use short form of Result

Harbormaster completed remote builds in B13723: Diff 18803.Nov 24 2022, 12:58 AM
Closed by commit rCOMM7790e0898b88: [services][blob] Introduce database client (authored by bartek). · Explain WhyNov 29 2022, 5:15 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM7790e0898b88: [services][blob] Introduce database client.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
77 lines
1 line

Diff 18591

View Options

services/blob/src/database.rs

Loading...
View Options

services/blob/src/main.rs

Loading...