This differential implements draft persistence on web via redux persist.
Details
Details
- Reviewers
tomek kamil ashoat - Commits
- rCOMM51c5910eadc4: Implement drafts persistence on web
Before this differential is applied: Write a message, but do not send( draft). Reload web app. Draft will disappear. After this differential is applied: Write draft, reload web application. Draft should remain.
Open web app and native app, logged as the same client. Start creating sidebar by typing draft on web. Create the same sidebar on native. Draft on web should remain even after window reload.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-2137
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/input/input-state-container.react.js | ||
|---|---|---|
| 126 | I think we should remove this from state, it's not clear to me why we're keeping two in-memory stores for this | |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 126 | We use it to create input state selector, where we rely on state.drafts. | |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 126 | Address that please | |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 126 | git grep PropsAndState | |
| web/input/input-state-container.react.js | ||
|---|---|---|
| 152–155 ↗ | (On Diff #18683) | Do we still need to be doing this here? Please make sure you understand what getDerivedStateFromProps was doing for the state.drafts state, and make sure it's still happening the same way now that drafts are in Redux. I think this diff breaks that functionality currently |
| web/chat/chat.react.js | ||
|---|---|---|
| 15–18 ↗ | (On Diff #18752) | I would move this below all of the use declarations |