Page MenuHomePhabricator
Differential D5730

[services][blob] Add meaningful logs in gRPC handler
ClosedPublic
Actions

Authored by bartek on Nov 28 2022, 2:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 1:39 PM
Unknown Object (File)
Fri, Dec 27, 1:39 PM
Unknown Object (File)
Fri, Dec 27, 1:39 PM
Unknown Object (File)
Fri, Dec 27, 1:39 PM
Unknown Object (File)
Fri, Dec 27, 1:38 PM
Unknown Object (File)
Fri, Dec 27, 1:28 PM
Unknown Object (File)
Fri, Dec 20, 2:42 PM
Unknown Object (File)
Fri, Dec 20, 2:14 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
tomek
marcin
ashoat
Commits
rCOMM9f551334c8ef: [services][blob] Add meaningful logs in gRPC handler
Summary

Related ENG-2308

Added log messages to the service handlers. I took advantage of spans/instruments and fields to make logs clean and structured.

Depends on D5729

Test Plan

RUST_LOG=blob=trace cargo run and interact with the service using BloomRPC and integration tests

Example logs: https://pastebin.com/dGNkrLET

Screenshot 2022-11-28 at 11.42.52.png (674×1 px, 858 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 28 2022, 2:23 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptNov 28 2022, 2:23 AM
bartek edited parent revisions, added: D5729: [services][blob] Use tracing for logs; removed: D5728: [services][blob] Upload 2/2 - Handle data chunks.Nov 28 2022, 2:24 AM
bartek edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B13772: Diff 18857.Nov 28 2022, 2:36 AM
bartek edited the test plan for this revision. (Show Details)Nov 28 2022, 2:43 AM
bartek attached a referenced file: F262893: Screenshot 2022-11-28 at 11.42.52.png. (Show Details)
bartek published this revision for review.Nov 28 2022, 2:54 AM
bartek mentioned this in D5728: [services][blob] Upload 2/2 - Handle data chunks.Nov 28 2022, 9:27 AM
tomek accepted this revision.Nov 28 2022, 10:08 AM
tomek added a reviewer: ashoat.

Looks great!

Adding @ashoat just to make sure that we're allowed to log these.

ashoat accepted this revision.Nov 28 2022, 12:06 PM

This should all be okay... blob hashes aren't personally identifiable

varun accepted this revision.Nov 28 2022, 11:09 PM
This revision is now accepted and ready to land.Nov 28 2022, 11:09 PM
bartek updated this revision to Diff 18926.Nov 29 2022, 3:51 AM
  • Rebase
  • Added two logs for errors introduced during rebase of previous diffs:
    • When content length read fails (in Get handler)
    • When holder / blob hash are not existing in PutHandler::finish()
Harbormaster completed remote builds in B13830: Diff 18926.Nov 29 2022, 4:02 AM
• jon accepted this revision.Nov 29 2022, 11:34 AM
bartek updated this revision to Diff 19008.Nov 30 2022, 6:43 AM

Rebase

This revision was landed with ongoing or failed builds.Nov 30 2022, 6:53 AM
Closed by commit rCOMM9f551334c8ef: [services][blob] Add meaningful logs in gRPC handler (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9f551334c8ef: [services][blob] Add meaningful logs in gRPC handler.
Harbormaster completed remote builds in B13880: Diff 19008.Nov 30 2022, 6:55 AM

Revision Contents
Changeset List

PathSize
services/
blob/
src/
167 lines

Diff 19010

View Options

services/blob/src/service.rs

Loading...