[services][blob] Let database helpers use new errors
ClosedPublic
Actions

Authored by bartek on Dec 13 2022, 8:21 AM.

Details

Reviewers

varun
• jon
tomek
michal

Commits

rCOMM54478432d88a: [services][blob] Let database helpers use new errors

Summary

Use previously defined errors in database code.

Depends on D5856

Test Plan

Purposefully caused a few attribute errors (e.g. saved blob with invalid timestamp format) to ensure they are handled correctly.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 13 2022, 8:21 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 13 2022, 8:21 AM

bartek added a child revision: D5858: [services][blob] Add custom errors to db methods.Dec 13 2022, 8:25 AM

Harbormaster completed remote builds in B14104: Diff 19304.Dec 13 2022, 8:32 AM

Rebase onto curretn master

bartek published this revision for review.Jan 23 2023, 3:25 PM

bartek added a reviewer: michal.

Harbormaster completed remote builds in B15533: Diff 21188.Jan 23 2023, 3:29 PM

• jon accepted this revision.Jan 23 2023, 6:10 PM

tomek accepted this revision.Jan 24 2023, 1:53 PM

varun accepted this revision.Jan 24 2023, 9:04 PM

This revision is now accepted and ready to land.Jan 24 2023, 9:04 PM

Closed by commit rCOMM54478432d88a: [services][blob] Let database helpers use new errors. · Explain WhyJan 25 2023, 10:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM54478432d88a: [services][blob] Let database helpers use new errors.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database.rs

66 lines

Diff 21306

View Options

services/blob/src/database.rs

[services][blob] Let database helpers use new errorsClosedPublicActions