[services][blob] Use new errors in service. Move logs
ClosedPublic
Actions

Authored by bartek on Dec 13 2022, 8:28 AM.

Details

Reviewers

varun
• jon
tomek
michal

Commits

rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs

Summary

Final diff with error adoption. Used new database errors in gRPC service.
I needed to move log messages to database, in order to avoid duplicating code.

S3 errors stay untouched, there is a separate task for that

Depends on D5858

Test Plan

Blob service integration tests should pass. Artificially caused database errors display proper log messages.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 13 2022, 8:28 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 13 2022, 8:28 AM

bartek edited the test plan for this revision. (Show Details)Dec 13 2022, 8:36 AM

Harbormaster completed remote builds in B14106: Diff 19306.Dec 13 2022, 8:39 AM

Rebase on typo fix in prev diff

Harbormaster completed remote builds in B14108: Diff 19308.Dec 13 2022, 8:54 AM

Rebase onto curretn master

bartek published this revision for review.Jan 23 2023, 3:25 PM

bartek added a reviewer: michal.

Harbormaster completed remote builds in B15535: Diff 21190.Jan 23 2023, 3:29 PM

• jon accepted this revision.Jan 23 2023, 6:12 PM

varun accepted this revision.Jan 24 2023, 9:10 PM

This revision is now accepted and ready to land.Jan 24 2023, 9:10 PM

Closed by commit rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs. · Explain WhyJan 25 2023, 10:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database.rs

39 lines

service.rs

82 lines

Diff 21308

View Options

services/blob/src/database.rs