Page MenuHomePhabricator
Differential D5859

[services][blob] Use new errors in service. Move logs
ClosedPublic
Actions

Authored by bartek on Dec 13 2022, 12:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 5:17 AM
Unknown Object (File)
Wed, Nov 13, 5:16 AM
Unknown Object (File)
Tue, Nov 5, 7:24 AM
Unknown Object (File)
Tue, Nov 5, 7:24 AM
Unknown Object (File)
Sun, Nov 3, 8:28 PM
Unknown Object (File)
Oct 29 2024, 8:49 PM
Unknown Object (File)
Oct 26 2024, 3:33 PM
Unknown Object (File)
Oct 18 2024, 11:32 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
varun
• jon
tomek
michal
Commits
rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs
Summary

Final diff with error adoption. Used new database errors in gRPC service.
I needed to move log messages to database, in order to avoid duplicating code.

S3 errors stay untouched, there is a separate task for that

Depends on D5858

Test Plan

Blob service integration tests should pass. Artificially caused database errors display proper log messages.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Dec 13 2022, 12:28 AM
bartek held this revision as a draft.
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 13 2022, 12:28 AM
bartek edited the test plan for this revision. (Show Details)Dec 13 2022, 12:36 AM
Harbormaster completed remote builds in B14106: Diff 19306.Dec 13 2022, 12:39 AM
bartek updated this revision to Diff 19308.Dec 13 2022, 12:42 AM

Rebase on typo fix in prev diff

Harbormaster completed remote builds in B14108: Diff 19308.Dec 13 2022, 12:54 AM
bartek updated this revision to Diff 21190.Jan 23 2023, 7:14 AM

Rebase onto curretn master

bartek published this revision for review.Jan 23 2023, 7:25 AM
bartek added a reviewer: michal.
Harbormaster completed remote builds in B15535: Diff 21190.Jan 23 2023, 7:29 AM
• jon accepted this revision.Jan 23 2023, 10:12 AM
varun accepted this revision.Jan 24 2023, 1:10 PM
This revision is now accepted and ready to land.Jan 24 2023, 1:10 PM
Closed by commit rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs (authored by bartek). · Explain WhyJan 25 2023, 2:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM38bc82fe2fce: [services][blob] Use new errors in service. Move logs.

Revision Contents
Changeset List

PathSize
services/
blob/
src/
39 lines
82 lines

Diff 21308

View Options

services/blob/src/database.rs

Loading...
View Options

services/blob/src/service.rs

Loading...