Page MenuHomePhabricator

[native/rust_library] Refactor Tonic client utility function names for Identity service
ClosedPublic

Authored by max on Dec 21 2022, 4:53 AM.
Tags
None
Referenced Files
F3492440: D5968.diff
Wed, Dec 18, 11:57 PM
F3491026: D5968.id20240.diff
Wed, Dec 18, 6:16 PM
F3491025: D5968.id20237.diff
Wed, Dec 18, 6:16 PM
F3491023: D5968.id19935.diff
Wed, Dec 18, 6:16 PM
F3488663: D5968.id.diff
Wed, Dec 18, 10:59 AM
Unknown Object (File)
Fri, Nov 29, 5:19 PM
Unknown Object (File)
Sun, Nov 24, 2:40 PM
Unknown Object (File)
Nov 15 2024, 9:50 AM
Subscribers

Details

Summary

This diff introduces refactoring the Tonic client utility function names for the Identity service in a Rust native library.
As we are using a single Rust library for the native which will contain clients and helper functions for all services we should refactor the Identity service-related function names to be more specific.
This refactoring adds an identity prefix to the function names.

Linear task: ENG-1333

Test Plan

Rust library and native app are successfully built.

Diff Detail

Repository
rCOMM Comm
Branch
restruct-native-rust-library-refactor-functions
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

max held this revision as a draft.
max retitled this revision from [native/rust_library] Refactor Tonic client function names for Identity service to [native/rust_library] Refactor Tonic client utility function names for Identity service.Dec 21 2022, 5:10 AM
max edited the summary of this revision. (Show Details)
max edited the test plan for this revision. (Show Details)
max added reviewers: varun, jon.
max added inline comments.
native/native_rust_library/src/lib.rs
16–19 ↗(On Diff #19935)

To not rename these functions it's better to call them directly with the parent name like: identity_client::get_user_id, this will add more clearance.

max published this revision for review.Dec 21 2022, 6:04 AM
varun added inline comments.
native/native_rust_library/src/lib.rs
16–19 ↗(On Diff #19935)

makes sense

This revision is now accepted and ready to land.Dec 21 2022, 2:03 PM

Fixing merging, rebasing on master.