Page MenuHomePhabricator
Differential D6104

Conditionally hide possibility to change password for SIWE accounts
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 8:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:48 AM
Unknown Object (File)
Wed, Dec 18, 11:15 PM
Unknown Object (File)
Mon, Dec 16, 12:50 AM
Unknown Object (File)
Tue, Dec 10, 6:13 PM
Unknown Object (File)
Sat, Nov 30, 4:03 PM
Unknown Object (File)
Sat, Nov 30, 6:55 AM
Unknown Object (File)
Thu, Nov 28, 11:18 AM
Unknown Object (File)
Thu, Nov 28, 11:18 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM170e8fede586: Conditionally hide possibility to change password for SIWE accounts
Summary

This differential disables UI that allows to change password for SIWE accounts.

Test Plan

Create SIWE accounts. Button to enter passowrd edition panel should simply not be visible, but everything should remain as it was for conventional accounts.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2541
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 8:11 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 8:11 AM
marcin published this revision for review.Dec 29 2022, 8:12 AM
marcin added a parent revision: D6103: Do not prompt for password when deleting thread.
Harbormaster failed remote builds in B14928: Diff 20345!Dec 29 2022, 8:15 AM
marcin added a child revision: D6105: Do not prompt for password when deleting thread on web.Dec 29 2022, 8:42 AM
marcin updated this revision to Diff 20357.Dec 29 2022, 8:49 AM

Rebase master

Harbormaster completed remote builds in B14939: Diff 20357.Dec 29 2022, 9:02 AM
marcin updated this revision to Diff 20422.Dec 30 2022, 3:37 AM

Rebase

Harbormaster completed remote builds in B14971: Diff 20422.Dec 30 2022, 3:51 AM
tomek accepted this revision.Dec 30 2022, 3:56 AM
This revision is now accepted and ready to land.Dec 30 2022, 3:56 AM
Closed by commit rCOMM170e8fede586: Conditionally hide possibility to change password for SIWE accounts (authored by marcin). · Explain WhyDec 30 2022, 4:13 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM170e8fede586: Conditionally hide possibility to change password for SIWE accounts.
ashoat added inline comments.Dec 30 2022, 6:32 AM
native/profile/profile-screen.react.js
104 ↗(On Diff #20431)

This should've been passwordEditingUI, "edition" doesn't mean what you think

marcin added inline comments.Dec 30 2022, 7:13 AM
native/profile/profile-screen.react.js
104 ↗(On Diff #20431)

Yes - language mistake from my side. I should create a small diff that fixes it shortly.

Revision Contents
Changeset List

PathSize
native/
profile/
36 lines

Diff 20345

View Options

native/profile/profile-screen.react.js

Loading...