Page MenuHomePhabricator
Differential D6123

[lib] add sendReactionMessageAction.started cases to message and local id reducers
ClosedPublic
Actions

Authored by ginsu on Dec 30 2022, 4:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 9:24 PM
Unknown Object (File)
Mon, Mar 17, 5:43 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:42 AM
Unknown Object (File)
Mon, Mar 17, 5:36 AM
Unknown Object (File)
Wed, Mar 12, 11:24 AM
Unknown Object (File)
Tue, Mar 11, 8:01 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM25322b6fd01b: [lib] add sendReactionMessageAction.started cases to message and local id…
Summary

add sendReactionMessageAction.started cases to message and local id reducers. The message reducer handles adding the local reaction message to the message store, and the local id reducer handles incrementing the local id

Depends on D6122
Linear Task: ENG-2520

Test Plan

Please watch the demo videos to see how the redux state changes when a sent reaction message action starts

Native:

Web:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 30 2022, 4:23 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 30 2022, 4:23 PM
Harbormaster completed remote builds in B14992: Diff 20461.Dec 30 2022, 4:36 PM
ginsu requested review of this revision.Dec 30 2022, 4:36 PM
ginsu planned changes to this revision.Dec 30 2022, 4:38 PM

Need to create demo videos for test plan

ginsu requested review of this revision.Jan 3 2023, 10:27 AM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6122: [native] add starting payload to send reaction message dispatch action promise.
ginsu attached a referenced file: F315193: Screen Recording 2023-01-03 at 1.15.50 PM.mov. (Show Details)
ginsu attached a referenced file: F315178: Screen Recording 2023-01-03 at 1.14.24 PM.mov. (Show Details)
ginsu mentioned this in D6119: [web] introduce localID field to useOnClickReact hook.Jan 3 2023, 10:29 AM
ginsu added a child revision: D6151: [lib/native/web] switch the promise type in sendReactionMessage action from SendReactionMessageResult to SendMessageResult.Jan 3 2023, 12:29 PM
tomek accepted this revision.Jan 5 2023, 3:54 AM
This revision is now accepted and ready to land.Jan 5 2023, 3:54 AM
ginsu updated this revision to Diff 20718.Jan 9 2023, 9:41 AM

rebase before landing

Harbormaster completed remote builds in B15203: Diff 20718.Jan 9 2023, 9:56 AM
Closed by commit rCOMM25322b6fd01b: [lib] add sendReactionMessageAction.started cases to message and local id… (authored by ginsu). · Explain WhyJan 9 2023, 10:05 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM25322b6fd01b: [lib] add sendReactionMessageAction.started cases to message and local id….

Revision Contents
Changeset List

PathSize
lib/
reducers/
2 lines
3 lines

Diff 20718

View Options

lib/reducers/local-id-reducer.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { ParserRules } from './markdown.js'; import type { ParserRules } from './markdown.js';
import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js'; import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js';
import { relationshipBlockedInEitherDirection } from './relationship-utils.js'; import { relationshipBlockedInEitherDirection } from './relationship-utils.js';
import { import {
createPendingThread, createPendingThread,
getSingleOtherUser, getSingleOtherUser,
extractMentionedMembers, extractMentionedMembers,
useThreadHasPermission, useThreadHasPermission,
userIsMember, userIsMember,
} from './thread-utils.js'; } from './thread-utils.js';
import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js'; import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js';
import { chatMessageItemEngagementTargetMessageInfo } from '../shared/chat-message-item-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import type { import type {
RobotextMessageInfo, RobotextMessageInfo,
ComposableMessageInfo, ComposableMessageInfo,
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
▲ Show 20 Lines • Show All 200 Lines • ▼ Show 20 Lines return (
!relationshipBlockedInEitherDirection(messageCreatorRelationship) !relationshipBlockedInEitherDirection(messageCreatorRelationship)
); );
} }
function useSidebarExistsOrCanBeCreated( function useSidebarExistsOrCanBeCreated(
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
messageItem: ChatMessageInfoItem, messageItem: ChatMessageInfoItem,
): boolean { ): boolean {
const engagementTargetMessageInfo =
chatMessageItemEngagementTargetMessageInfo(messageItem);
const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage( const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage(
threadInfo, threadInfo,
messageItem.messageInfo, engagementTargetMessageInfo,
); );
return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage; return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage;
} }
export { export {
createUnresolvedPendingSidebar, createUnresolvedPendingSidebar,
createPendingSidebar, createPendingSidebar,
useCanCreateSidebarFromMessage, useCanCreateSidebarFromMessage,
useSidebarExistsOrCanBeCreated, useSidebarExistsOrCanBeCreated,
}; };
View Options

lib/reducers/message-reducer.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import type { ParserRules } from './markdown.js'; import type { ParserRules } from './markdown.js';
import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js'; import { getMessageTitle, isInvalidSidebarSource } from './message-utils.js';
import { relationshipBlockedInEitherDirection } from './relationship-utils.js'; import { relationshipBlockedInEitherDirection } from './relationship-utils.js';
import { import {
createPendingThread, createPendingThread,
getSingleOtherUser, getSingleOtherUser,
extractMentionedMembers, extractMentionedMembers,
useThreadHasPermission, useThreadHasPermission,
userIsMember, userIsMember,
} from './thread-utils.js'; } from './thread-utils.js';
import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js'; import type { ChatMessageInfoItem } from '../selectors/chat-selectors.js';
import { chatMessageItemEngagementTargetMessageInfo } from '../shared/chat-message-item-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import type { import type {
RobotextMessageInfo, RobotextMessageInfo,
ComposableMessageInfo, ComposableMessageInfo,
} from '../types/message-types.js'; } from '../types/message-types.js';
import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
▲ Show 20 Lines • Show All 200 Lines • ▼ Show 20 Lines return (
!relationshipBlockedInEitherDirection(messageCreatorRelationship) !relationshipBlockedInEitherDirection(messageCreatorRelationship)
); );
} }
function useSidebarExistsOrCanBeCreated( function useSidebarExistsOrCanBeCreated(
threadInfo: ThreadInfo, threadInfo: ThreadInfo,
messageItem: ChatMessageInfoItem, messageItem: ChatMessageInfoItem,
): boolean { ): boolean {
const engagementTargetMessageInfo =
chatMessageItemEngagementTargetMessageInfo(messageItem);
const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage( const canCreateSidebarFromMessage = useCanCreateSidebarFromMessage(
threadInfo, threadInfo,
messageItem.messageInfo, engagementTargetMessageInfo,
); );
return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage; return !!messageItem.threadCreatedFromMessage || canCreateSidebarFromMessage;
} }
export { export {
createUnresolvedPendingSidebar, createUnresolvedPendingSidebar,
createPendingSidebar, createPendingSidebar,
useCanCreateSidebarFromMessage, useCanCreateSidebarFromMessage,
useSidebarExistsOrCanBeCreated, useSidebarExistsOrCanBeCreated,
}; };