[lib] change the Send Reaction Message Success Payload and also change its reducer success case
ClosedPublic
Actions

Authored by ginsu on Jan 3 2023, 12:30 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM8c628ce6e050: [lib] change the Send Reaction Message Success Payload and also change its…

Summary

change the Send Reaction Message Success Payload and also change its reducer success case. The big change here is that we no longer want to use the same success case as restoreEntryActionTypes, changeThreadSettingsActionTypes, etc. With localID we can use the same success case as sendTextMessageActionTypes and sendMultimediaMessageActionTypes since we are grabbing the message info from the local message.

Also got rid of SendReactionMessagePayload since we are just using SendMessagePayload for reaction messages

Depends on D6151
Linear Task: ENG-2599

Test Plan

Please watch the demo videos to see how the redux state changes when a reaction message is successful:

Native:

Web:

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 3 2023, 12:30 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 3 2023, 12:31 PM

Harbormaster completed remote builds in B15050: Diff 20531.Jan 3 2023, 12:45 PM

ginsu requested review of this revision.Jan 3 2023, 12:45 PM

ginsu retitled this revision from [lib] change the Send Reaction Message Success Payload and also change its reducer case to [lib] change the Send Reaction Message Success Payload and also change its reducer success case.Jan 3 2023, 12:50 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, tomek.

ginsu added a parent revision: D6151: [lib/native/web] switch the promise type in sendReactionMessage action from SendReactionMessageResult to SendMessageResult.

ginsu attached a referenced file: F315529: Screen Recording 2023-01-03 at 3.48.38 PM.mov. (Show Details)

ginsu attached a referenced file: F315509: Screen Recording 2023-01-03 at 3.46.23 PM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)Jan 3 2023, 1:00 PM

ginsu added a child revision: D6154: [lib/native/web] handle send reaction message action failed case.Jan 3 2023, 1:52 PM

tomek accepted this revision.Jan 5 2023, 8:14 AM

This revision is now accepted and ready to land.Jan 5 2023, 8:14 AM

rebase before landing

Harbormaster completed remote builds in B15205: Diff 20720.Jan 9 2023, 9:57 AM