[native] Add 'internal-ip' dependency
ClosedPublic
Actions

Authored by bartek on Jan 14 2023, 8:30 AM.

Details

Reviewers

ashoat

Commits

rCOMM60687af2d8e5: [native] Add 'internal-ip' dependency

Summary

Added internal-ip to devDependencies in native package.json.
I used the same exact version as the @expo/cli uses, so the yarn.lock remains unchanged.

The latest version of this library (7.0.0) is ESM-only, this is why the old 4.3.0 is used.

Test Plan

yarn cleaninstall doesn't do any changes to yarn.lock

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 14 2023, 8:30 AM

bartek held this revision as a draft.

Herald added subscribers: atul, tomek. · View Herald TranscriptJan 14 2023, 8:30 AM

bartek added a child revision: D6267: [native] Add 'natDevHostname' field to Expo config.Jan 14 2023, 8:40 AM

Harbormaster completed remote builds in B15372: Diff 20962.Jan 14 2023, 8:44 AM

bartek published this revision for review.Jan 14 2023, 9:27 AM

Just wondering, what's the issue using an ESM-only library?

This revision is now accepted and ready to land.Jan 14 2023, 5:13 PM

In D6266#187902, @ashoat wrote:

Just wondering, what's the issue using an ESM-only library?

Expo-CLI that parses app.config.js doesn't support ESM and fails with error similar to this:

Module 'internal-ip' cannot be imported using this construct. The specifier only resolves to an ES module, which cannot be imported synchronously. Use dynamic import instead.

Dynamic imports cannot be used, because the expo config must be resolved synchronously

Closed by commit rCOMM60687af2d8e5: [native] Add 'internal-ip' dependency (authored by bartek). · Explain WhyJan 19 2023, 12:02 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM60687af2d8e5: [native] Add 'internal-ip' dependency.

rohan mentioned this in D6587: [keyserver] Use the internal-ip package in the dev environment to ensure physical device / emulators can access uploads.Feb 4 2023, 3:28 PM

rohan mentioned this in rCOMMc5e3e7ca5bc8: [keyserver] Use the internal-ip package in the dev environment to ensure….Feb 26 2023, 11:49 AM