[buildkite] Adding CI test for the Tunnelbroker client shared library
ClosedPublic
Actions

Authored by • max on Jan 17 2023, 6:35 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMM48ba3b6f41fa: [buildkite] Adding CI test for the Tunnelbroker client shared library

Summary

This diff adds a Buildkite CI test for the Tunnelbroker client-shared library.
By running the cargo build and cargo test from the Nix in our CI we will make sure that the diffs changes are passing the CI test for the Tunnelbroker client library.

Linear task: ENG-2728

Test Plan

Running commands in the buildkite file from the project's root results in a Tunnelbroker client shared library successfully build.

Diff Detail

Repository

rCOMM Comm

Branch

buildkite-add-tb-client

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jan 17 2023, 6:35 AM

• max held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 6:35 AM

Harbormaster completed remote builds in B15399: Diff 20999.Jan 17 2023, 6:48 AM

• max published this revision for review.Jan 17 2023, 7:22 AM

• max retitled this revision from [buildkite] Adding CI test for the Tunnelbroker shared library to [buildkite] Adding CI test for the Tunnelbroker client shared library.

• max edited the summary of this revision. (Show Details)

• max edited the test plan for this revision. (Show Details)

• max added reviewers: • jon, bartek.

Great idea creating this at the start instead of at the end!

atul added inline comments.Jan 17 2023, 11:02 AM

.buildkite/tunnelbroker_client.yml
1–2 ↗	(On Diff #20999)	Are we sure we want to be putting this in the Buildkite config?

• jon added inline comments.Jan 17 2023, 11:10 AM

.buildkite/tunnelbroker_client.yml
1–2 ↗	(On Diff #20999)	it was a mitigation for updating the mac might nuke `/etc/zshrc` which is how nix normal exports this.
8 ↗	(On Diff #20999)	should just be able to do

• jon requested changes to this revision.Jan 17 2023, 11:23 AM

This revision now requires changes to proceed.Jan 17 2023, 11:23 AM

• max planned changes to this revision.Jan 18 2023, 5:38 AM

Minimize cargo command. Rebasing.

• max marked an inline comment as done.Jan 25 2023, 4:49 AM

• max added inline comments.

.buildkite/tunnelbroker_client.yml
1–2 ↗	(On Diff #20999)	Are we sure we want to be putting this in the Buildkite config? Yes, it came from another nix-related tests.
8 ↗	(On Diff #20999)	should just be able to do Make sense to just do a 'test' while it's building anyway. Thanks!