Page MenuHomePhabricator
Differential D6360

[native] Use getMessagePreview in native MessagePreview
ClosedPublic
Actions

Authored by ashoat on Jan 23 2023, 2:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Thu, Oct 31, 3:51 PM
Unknown Object (File)
Thu, Oct 24, 2:31 AM
Unknown Object (File)
Tue, Oct 22, 3:18 AM
Unknown Object (File)
Tue, Oct 22, 3:18 AM
View All 93 Files
Subscribers
None

Details

Reviewers
inka
ginsu
atul
tomek
Commits
rCOMM463bca6ba7c7: [native] Use getMessagePreview in native MessagePreview
Summary

After D6357 updated getMessagePreview to return a style for each portion, we can update native to use that function to unify codepaths with web.

This should be a no-op. Compare to web's version of MessagePreview in D6358 – very similar code.

Depends on D6359

Test Plan
beforeafter
Screenshot 2023-01-23 at 5.47.44 PM.png (2×1 px, 936 KB)
Screenshot 2023-01-23 at 5.47.29 PM.png (2×1 px, 936 KB)

(should be identical)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jan 23 2023, 2:55 PM
ashoat edited the test plan for this revision. (Show Details)Jan 23 2023, 2:58 PM
ashoat edited the test plan for this revision. (Show Details)Jan 23 2023, 3:02 PM
ashoat edited the summary of this revision. (Show Details)
ashoat edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B15573: Diff 21237.Jan 23 2023, 3:09 PM
ashoat requested review of this revision.Jan 23 2023, 3:09 PM
atul accepted this revision.Jan 24 2023, 11:26 AM
atul added inline comments.
native/chat/message-preview.react.js
50–55

Could probably do

const usernameStyle =
  username.style === 'unread' ? styles.unread : styles.secondary;

?

This revision is now accepted and ready to land.Jan 24 2023, 11:26 AM
ashoat added inline comments.Jan 24 2023, 2:40 PM
native/chat/message-preview.react.js
50–55

I want to keep the invariant so people don't accidentally use something that's unsupported

Closed by commit rCOMM463bca6ba7c7: [native] Use getMessagePreview in native MessagePreview (authored by ashoat). · Explain WhyJan 24 2023, 3:06 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM463bca6ba7c7: [native] Use getMessagePreview in native MessagePreview.

Revision Contents
Changeset List

PathSize
native/
chat/
102 lines

Diff 21237

View Options

native/chat/message-preview.react.js

Loading...