Page MenuHomePhabricator
Differential D6622

[services] Tunnelbroker - Disable messages persistence config parameter
ClosedPublic
Actions

Authored by • max on Feb 6 2023, 2:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 1:03 PM
Unknown Object (File)
Thu, Apr 17, 8:14 AM
Unknown Object (File)
Thu, Apr 17, 7:23 AM
Unknown Object (File)
Thu, Apr 17, 5:53 AM
Unknown Object (File)
Wed, Apr 16, 12:29 PM
Unknown Object (File)
Mar 22 2025, 7:37 PM
Unknown Object (File)
Mar 10 2025, 10:34 PM
Unknown Object (File)
Mar 6 2025, 6:34 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM43468c1caea8: [services] Tunnelbroker - Disable messages persistence config parameter
Summary

This diff introduces adding the messages.skip_persistence config flag to disable the persistence of the message using the DynamoDB database in a Tunnelbroker.

Linear task: ENG-2641

Test Plan

Adding the skip_persistence flag to the [messages] section of the config file results in a true return from the isParameterSet('messages.skip_persistence') function call.

Diff Detail

Repository
rCOMM Comm
Branch
add-skip-messages-persistence
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Feb 6 2023, 2:47 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptFeb 6 2023, 2:47 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald Transcript
• max added a child revision: D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.Feb 6 2023, 2:59 AM
Harbormaster completed remote builds in B16165: Diff 22115.Feb 6 2023, 3:08 AM
• max edited the summary of this revision. (Show Details)Feb 6 2023, 5:16 AM
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: bartek.
• max mentioned this in D6623: [services] Tunnelbroker - Disabling checking of the persisted messages on stream connect.Feb 6 2023, 5:23 AM
• max mentioned this in D6624: [services] Tunnelbroker - Disabling messages persistence on messages send.Feb 6 2023, 5:27 AM
• max mentioned this in D6625: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate function.Feb 6 2023, 5:36 AM
• max published this revision for review.Feb 6 2023, 5:45 AM
• max mentioned this in D6626: [services] Tunnelbroker - Disabling messages persistence on messages removing.
• jon accepted this revision.Feb 7 2023, 9:01 AM
This revision is now accepted and ready to land.Feb 7 2023, 9:01 AM
bartek accepted this revision.Feb 12 2023, 10:33 PM
• max updated this revision to Diff 22977.Feb 23 2023, 4:23 AM

Rebasing on master, fixing based on D6749 changes.

Harbormaster completed remote builds in B16808: Diff 22977.Feb 23 2023, 4:39 AM
Closed by commit rCOMM43468c1caea8: [services] Tunnelbroker - Disable messages persistence config parameter (authored by • max). · Explain WhyFeb 23 2023, 4:42 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM43468c1caea8: [services] Tunnelbroker - Disable messages persistence config parameter.
• max mentioned this in rCOMM343be0ba9181: [services] Tunnelbroker - Disabling checking of the persisted messages on….Feb 23 2023, 4:48 AM
• max mentioned this in rCOMMf95747ecac53: [services] Tunnelbroker - Disabling messages persistence on messages send.Feb 23 2023, 5:00 AM
• max mentioned this in rCOMMc7c87fa04cab: [services] Tunnelbroker - Extracting `deleteQueueIfEmpty` logic to a separate….Feb 23 2023, 5:08 AM
• max mentioned this in rCOMM7fa036f59002: [services] Tunnelbroker - Disabling messages persistence on messages removing.Feb 23 2023, 5:12 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
libcpp/
src/
Tools/
1 line
7 lines

Diff 22977

View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.h

Loading...
View Options

services/tunnelbroker/src/libcpp/src/Tools/ConfigManager.cpp

Loading...