You'll need to rebase on D6784

I forget why we did it this way, but there may have (not sure) been a good reason. It's worth testing to make sure you're not breaking anything here. I worry about testing because I'm not sure how you were able to get this to work without D6784 (maybe you don't have D6695 either?)

Avoid interface, use declare type if at all possible

You'll need to rebase on D6784

Rebased, thanks for pointing out this.

I forget why we did it this way, but there may have (not sure) been a good reason. It's worth testing to make sure you're not breaking anything here.

I've tested it, nativeBinding have a default object, and registerUser, TunnelbrokerClient inside it.
I'm asking @jon did he tested it in D6790 without default?
Because @varun has the same approach and used default in his diff.
I'll update testing plan on my changes as I'll make work the following diff in the stack, but simply getting the nativeBinding to the console shows that the default should be used first. cc @jon

Avoid interface, use declare type if at all possible

We have a Class for the Tunnelbroker client and seems that in flow we can only declare a class, but it's derived from the napi-rs bridge generation. It seems only the interface can be used here.

1. We definitely need to get rid of default here. You haven't tested after rebasing, and you didn't look closely enough at the merge conflicts when resolving them.
2. I'm still not sure about returning nativeBinding directly, vs. destructuring nativeBinding and return the functions directly. If you've tested this, that's good... but I worry that you haven't tested, since otherwise you would've realized that default doesn't work.

1. We definitely need to get rid of default here. You haven't tested after rebasing, and you didn't look closely enough at the merge conflicts when resolving them.

My fault! We no longer need .default with the recent changes from D6784.

2. I'm still not sure about returning nativeBinding directly, vs. destructuring nativeBinding and return the functions directly. If you've tested this, that's good... but I worry that you haven't tested, since otherwise you would've realized that default doesn't work.

It can be tested easily by adding a simple code to the keyserver/src/keyserver.js:

    import { getRustAPI } from 'rust-node-addon';
...
    const rustBinding = await getRustAPI();
    const tbClientBinding = rustBinding.TunnelbrokerClient;
    const tbClient = new tbClientBinding('ksID', (error, msg) => {
      console.log(`tbClient got: ${msg}`);
      if (error) {
        console.log(`tbClient got an error: ${error.toString()}`);
      }
    });
    tbClient.publish('someOtherID', 'Hello from keyserver');

I've tested it and we can return nativeBinding directly.