Page MenuHomePhabricator
Differential D6774

Start NotificationsCryptoModule API definition and implementation
ClosedPublic
Actions

Authored by marcin on Feb 20 2023, 4:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 3:30 AM
Unknown Object (File)
Sat, Nov 23, 3:25 PM
Unknown Object (File)
Thu, Oct 31, 7:33 PM
Unknown Object (File)
Wed, Oct 30, 7:58 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
Unknown Object (File)
Wed, Oct 30, 7:57 AM
View All Files
Subscribers
ashoat
• jon

Details

Reviewers
tomek
bartek
atul
• jon
Commits
rCOMMbc8301ae6a64: Start NotificationsCryptoModule API definition and implementation
Summary

This differential launches definition and implementation of NotificationsCryptoModule C++ API. Foundational methods to serialize and deserialize file containing notifications olm account are defined. Relevant build files on both platforms are also modified.

Test Plan

There is not test plan for this differential. Header files are not compiled if there is no cpp file including them. Very next differentials are going to include this file and implement methods from this file.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 20 2023, 4:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 20 2023, 4:05 AM
marcin added a parent revision: D6773: Extend PlatformSpecificTools CommonCpp api with an API to retrieve notifications olm account storage path.Feb 20 2023, 4:05 AM
marcin retitled this revision from Start NotificationsCryptoModule API definitiaon and implementation to Start NotificationsCryptoModule API definition and implementation.
marcin added a child revision: D6775: Implement method to deserialize olm account from a file.Feb 20 2023, 4:19 AM
marcin published this revision for review.Feb 20 2023, 4:43 AM
Harbormaster failed remote builds in B16604: Diff 22710!Feb 20 2023, 7:23 AM
ashoat added a reviewer: • jon.Feb 20 2023, 3:46 PM
ashoat added a subscriber: • jon.

Any change to CMake files should go through @jon, especially native/android/app/CMakeLists.txt

• jon accepted this revision.Feb 20 2023, 6:19 PM

I plan on improving this anyway, looks good for now.

This revision is now accepted and ready to land.Feb 20 2023, 6:19 PM
bartek accepted this revision.Feb 21 2023, 4:08 AM
marcin updated this revision to Diff 22878.Feb 21 2023, 10:48 AM

Rebase

Harbormaster failed remote builds in B16723: Diff 22878!Feb 21 2023, 11:02 AM
Harbormaster completed remote builds in B16723: Diff 22878.Feb 21 2023, 11:31 AM
marcin updated this revision to Diff 23252.Feb 28 2023, 10:05 AM

Rebase before landing

Harbormaster failed remote builds in B16998: Diff 23252!Feb 28 2023, 10:12 AM
Harbormaster completed remote builds in B16998: Diff 23252.Feb 28 2023, 1:49 PM
marcin updated this revision to Diff 23306.Mar 1 2023, 1:20 AM

Rebase before landing

Harbormaster completed remote builds in B17023: Diff 23306.Mar 1 2023, 1:38 AM
Closed by commit rCOMMbc8301ae6a64: Start NotificationsCryptoModule API definition and implementation (authored by marcin). · Explain WhyMar 1 2023, 2:04 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbc8301ae6a64: Start NotificationsCryptoModule API definition and implementation.

Revision Contents
Changeset List

PathSize
native/
android/
app/
4 lines
cpp/
CommonCpp/
Notifications/
BackgroundDataStorage/
27 lines
ios/
Comm.xcodeproj/
18 lines

Diff 22878

View Options

native/android/app/CMakeLists.txt

Loading...
View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h

Loading...
View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...