Details

Reviewers

tomek
atul
bartek
kamil

Commits

rCOMMa91b1a96bd3e: Implement method to sign message

Summary

This differential implements method to sign a message using private ed25519 key of an olm account. Counterpart method to verify signature is implemented as well

Test Plan

In CommCoreModule call this method on cryptoModule attribute on some data. Copy returned signature. Pass this signatur back to verify method, ensure app does not crash.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-2901

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Feb 21 2023, 10:41 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 21 2023, 10:41 AM

marcin added a parent revision: D6781: Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.Feb 21 2023, 10:41 AM

marcin retitled this revision from Implement method to sind message to Implement method to sign message.Feb 21 2023, 10:44 AM

marcin added a child revision: D6822: Sign concatenation of public and notif keypairs using private key of public identity.

Harbormaster completed remote builds in B16719: Diff 22874.Feb 21 2023, 10:55 AM

marcin requested review of this revision.Feb 21 2023, 10:55 AM

Great work finding the right utilities in the Olm library!!

bartek added inline comments.Feb 24 2023, 5:11 AM

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
337	Should this be an `"olm error" + empty string`?

marcin added inline comments.Feb 24 2023, 5:14 AM

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
337	Thanks for catching! This is definitely a mistake, we should extract last error from utility object as we do from account in `signMessage` method. I will change it.