Page MenuHomePhabricator
Differential D6842

[web] Add navigation state info to the topbar
ClosedPublic
Actions

Authored by inka on Feb 23 2023, 1:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 9:59 AM
Unknown Object (File)
Tue, Nov 19, 9:36 AM
Unknown Object (File)
Oct 21 2024, 3:40 PM
Unknown Object (File)
Oct 21 2024, 3:40 PM
Unknown Object (File)
Oct 21 2024, 3:40 PM
Unknown Object (File)
Oct 18 2024, 5:40 PM
View All 97 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
kamil
michal
bartek
Commits
rCOMMf50f8f28a5ba: [web] Add navigation state info to the topbar
Summary

issue: https://linear.app/comm/issue/ENG-2740/add-navigation-state-info-to-the-top-bar
Add NavStateInfoBar to the topbar.

Test Plan

Run web app, checked that the navigation state info shows up in the topbar, and the animations work correclty.

Diff Detail

Repository
rCOMM Comm
Branch
inka/web_drawer_continuation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 23 2023, 1:05 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 23 2023, 1:05 AM
inka edited the summary of this revision. (Show Details)Feb 23 2023, 1:05 AM
inka attached a referenced file: F397540: Screen Recording 2023-02-21 at 15.33.35.mov. (Show Details)
inka added a parent revision: D6841: [web] Add PossiblyEmptyNavStateInfoBar to handle collapse animation in the topbar when no community is selected.
Harbormaster completed remote builds in B16795: Diff 22964.Feb 23 2023, 1:19 AM
inka requested review of this revision.Feb 23 2023, 1:19 AM
inka added a child revision: D6845: [web] Style navigation state info in the top bar.Feb 23 2023, 5:16 AM
inka mentioned this in D6848: [web] Fix filter panel showing over the topbar.Feb 23 2023, 5:28 AM
bartek accepted this revision.Feb 24 2023, 5:45 AM
This revision is now accepted and ready to land.Feb 24 2023, 5:45 AM
Closed by commit rCOMMf50f8f28a5ba: [web] Add navigation state info to the topbar (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMf50f8f28a5ba: [web] Add navigation state info to the topbar.
• InkaSokolowska mentioned this in rCOMM4bd6b6c4efa6: [web] Fix filter panel showing over the topbar.

Revision Contents
Changeset List

PathSize
web/
navigation-panels/
19 lines

Diff 22964

View Options

web/navigation-panels/topbar.react.js

Loading...