Page MenuHomePhabricator
Differential D6848

[web] Fix filter panel showing over the topbar
ClosedPublic
Actions

Authored by inka on Feb 23 2023, 5:28 AM.
Tags
None
Referenced Files
F3360550: D6848.diff
Sun, Nov 24, 1:21 PM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 10:01 AM
Unknown Object (File)
Tue, Nov 19, 9:59 AM
Unknown Object (File)
Tue, Nov 19, 9:36 AM
Unknown Object (File)
Thu, Nov 7, 5:51 PM
Unknown Object (File)
Mon, Nov 4, 6:11 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
kamil
bartek
Commits
rCOMM4bd6b6c4efa6: [web] Fix filter panel showing over the topbar
Summary

Filter panel used to have a fixed height. This is no longer possible, because since D6842 the topbars height is dynamic.

Test Plan

Run web app, checked that the filter panel is now correctly positioned under the topbar in all cases.

Diff Detail

Repository
rCOMM Comm
Branch
inka/web_drawer_continuation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Feb 23 2023, 5:28 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 23 2023, 5:28 AM
inka added a parent revision: D6845: [web] Style navigation state info in the top bar.Feb 23 2023, 5:28 AM
inka edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B16816: Diff 22990.Feb 23 2023, 5:43 AM
inka requested review of this revision.Feb 23 2023, 5:43 AM
bartek accepted this revision.Feb 24 2023, 5:50 AM

As far as I understand CSS, looks good to me 😅

This revision is now accepted and ready to land.Feb 24 2023, 5:50 AM
inka attached a referenced file: F398161: Screen Recording 2023-02-23 at 14.29.00.mov. (Show Details)Feb 27 2023, 12:39 PM
inka updated this revision to Diff 23668.Mar 13 2023, 4:13 AM

Rebase

Harbormaster completed remote builds in B17279: Diff 23668.Mar 13 2023, 4:27 AM
Closed by commit rCOMM4bd6b6c4efa6: [web] Fix filter panel showing over the topbar (authored by • InkaSokolowska). · Explain WhyMar 13 2023, 6:35 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM4bd6b6c4efa6: [web] Fix filter panel showing over the topbar.

Revision Contents
Changeset List

PathSize
web/
calendar/
6 lines
6 lines
3 lines

Diff 22990

View Options

web/calendar/calendar.css

Loading...
View Options

web/calendar/calendar.react.js

Loading...
View Options

web/calendar/filter-panel.css

Loading...