Page MenuHomePhabricator

[keyserver] Extend ios notifs to handle macos
ClosedPublic

Authored by michal on Feb 24 2023, 9:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 12, 10:07 AM
Unknown Object (File)
Wed, Jun 12, 6:54 AM
Unknown Object (File)
Sun, May 26, 11:40 PM
Unknown Object (File)
May 11 2024, 10:21 AM
Unknown Object (File)
May 11 2024, 10:21 AM
Unknown Object (File)
May 11 2024, 12:01 AM
Unknown Object (File)
May 11 2024, 12:01 AM
Unknown Object (File)
May 11 2024, 12:01 AM
Subscribers

Details

Summary

We can reuse most of out already existing code for macOS notifs. This diff mostly just replaces codeVersion with full platformDetails so we can pass a platform and change for example the apn topic depending if we are sending the notifcation to the ios or macos.

Depends on D6891

Test Plan

Check if notifications still work on ios

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
keyserver/src/push/send.js
177 ↗(On Diff #23070)

We construct this already on line 167. Instead of doing twice, maybe we should assign to a variable?

This revision is now accepted and ready to land.Feb 26 2023, 4:43 AM

Extract platformDetails variables.