Page MenuHomePhabricator

[keyserver] Send macos notifications
ClosedPublic

Authored by michal on Feb 24 2023, 10:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 21, 2:09 PM
Unknown Object (File)
Wed, Feb 21, 2:09 PM
Unknown Object (File)
Wed, Feb 21, 2:09 PM
Unknown Object (File)
Wed, Feb 21, 2:09 PM
Unknown Object (File)
Wed, Feb 21, 9:15 AM
Unknown Object (File)
Wed, Feb 21, 9:15 AM
Unknown Object (File)
Wed, Feb 21, 9:15 AM
Unknown Object (File)
Tue, Feb 20, 3:27 AM
Subscribers

Details

Summary

Actually send the notification to all macos devices. One things that is different is that we don't include text for alert notif so it doesn't display automatically by macos but we handle the visible notification ourselves. More information in ENG-3056.

Test Plan

Tested with the next diff, if the notifications are sent correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It looks like you're adding support for sending push notifs, but support is still missing for rescinds and for updateBadgeCount. Rescinds may be hard but updateBadgeCount should be easy.

Before landing, can you create Linear tasks for each?

keyserver/src/push/send.js
546 ↗(On Diff #23071)

Can you add a code comment explaining why we don't include body or sounds for macOS?

This revision is now accepted and ready to land.Feb 26 2023, 4:47 AM

Add comment, tasks: ENG-3173, ENG-3174

Extract platformDetails variable

keyserver/src/push/send.js
619 ↗(On Diff #23260)

Nit