Page MenuHomePhabricator
Differential D6891

[desktop/web] Expose callbacks needed for desktop notifications
ClosedPublic
Actions

Authored by michal on Feb 24 2023, 9:34 AM.
Tags
None
Referenced Files
F3695748: D6891.id.diff
Tue, Jan 7, 11:10 AM
F3695747: D6891.diff
Tue, Jan 7, 11:10 AM
Unknown Object (File)
Tue, Jan 7, 8:55 AM
Unknown Object (File)
Tue, Jan 7, 8:54 AM
Unknown Object (File)
Wed, Jan 1, 2:29 PM
Unknown Object (File)
Wed, Jan 1, 2:29 PM
Unknown Object (File)
Wed, Jan 1, 2:22 PM
Unknown Object (File)
Wed, Dec 25, 7:09 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
inka
kamil
Commits
rCOMMbad1e6527635: [desktop/web] Expose callbacks needed for desktop notifications
Summary

For macos notifs we need to expose two functionalities from the web app to the desktop app:

  • setting the device_token that we will get from native macos api
  • navigate to a thread after a notification is clicked
Test Plan

Tested with the rest of the stack, if the device token is set correctly and the app navigates to a thread.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
desktop/
src/
12 lines
lib/
types/
6 lines
web/
push-notif/
33 lines

Diff 23300

View Options

desktop/src/preload.js

Loading...
View Options

lib/types/electron-types.js

Loading...
View Options

web/push-notif/push-notifs-handler.js

Loading...