Details
Created a blob larger than 5MB through gRPC API and called this endpoint using Postman. Ensured the response is correct.
Checked if HTTP 404 is returned when blob doesn't exist.
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/blob/src/http/handlers/blob.rs | ||
|---|---|---|
| 48–52 ↗ | (On Diff #25216) | If we have the data local to the blob service, I think this makes sense. However, having to stream some bytes from a s3 service to the blob service, then re-emit them to the client seems like a lot of I/O pressure on the blob service. Are we able to do something like https://docs.aws.amazon.com/AmazonS3/latest/userguide/ShareObjectPreSignedURL.html where we can just pass the client a non-shareable but usable url? |
| services/blob/src/http/mod.rs | ||
| 16–17 ↗ | (On Diff #25216) | if it has public visibility, should be able to remove the allow(unused). May need to add pub at the mod level as well. |
| services/blob/src/http/handlers/blob.rs | ||
|---|---|---|
| 48–52 ↗ | (On Diff #25216) | I considered pre-signed URLs initially but wanted to avoid exposing them by blob service. Moreover, this complicates both client-side (two calls instead of one) and requires additional configuration on blob service side. |
| services/blob/src/http/mod.rs | ||
| 16–17 ↗ | (On Diff #25216) | The pub would expose this outside handlers module which I don't want. The unused is for handle_db_error which is used in the next diff |