[services][blob] Add assign holder HTTP endpoint
ClosedPublic
Actions

Authored by bartek on Apr 18 2023, 12:00 AM.

Details

Reviewers

marcin
tomek
michal
• jon

Commits

rCOMMb33fc5ca590b: [services][blob] Add assign holder HTTP endpoint

Summary

This diff implements endpoint to assign holder to a blob instance. Details are in the linear task. Ensuring that the blob exists is done in a separate diff.

Depends on D7466

Test Plan

Executed this endpoint for:

non-existing blob - false is returned in response
existing blob - true is returned in response. Also checked if holder is assigned to blob in DB (a reverse index is created).
already existing holder - HTTP 409 is returned

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 18 2023, 12:00 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 18 2023, 12:00 AM

bartek added a child revision: D7483: [services][blob] Add upload blob HTTP handler.Apr 18 2023, 12:04 AM

Harbormaster completed remote builds in B18436: Diff 25251.Apr 18 2023, 12:18 AM

bartek published this revision for review.Apr 18 2023, 8:23 AM

• jon accepted this revision.Apr 18 2023, 9:44 AM

This revision is now accepted and ready to land.Apr 18 2023, 9:44 AM

Rebase

Harbormaster completed remote builds in B18695: Diff 25601.Apr 24 2023, 6:06 AM

Closed by commit rCOMMb33fc5ca590b: [services][blob] Add assign holder HTTP endpoint (authored by bartek). · Explain WhyApr 25 2023, 5:19 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb33fc5ca590b: [services][blob] Add assign holder HTTP endpoint.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

blob.rs

56 lines

mod.rs

4 lines

Diff 25656

View Options

services/blob/src/http/handlers/blob.rs

	// @flow			// @flow

				import { useRoute } from '@react-navigation/native';
	import * as React from 'react';			import * as React from 'react';
	import { View } from 'react-native';			import { View } from 'react-native';

	import { useStringForUser } from 'lib/hooks/ens-cache.js';			import { useStringForUser } from 'lib/hooks/ens-cache.js';

	import { clusterEndHeight, avatarOffset } from './chat-constants.js';			import { clusterEndHeight, avatarOffset } from './chat-constants.js';
	import type { DisplayType } from './timestamp.react.js';			import type { DisplayType } from './timestamp.react.js';
	import { Timestamp, timestampHeight } from './timestamp.react.js';			import { Timestamp, timestampHeight } from './timestamp.react.js';
	import { SingleLine } from '../components/single-line.react.js';			import { SingleLine } from '../components/single-line.react.js';
				import { MessageListRouteName } from '../navigation/route-names.js';
	import { useStyles } from '../themes/colors.js';			import { useStyles } from '../themes/colors.js';
	import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';			import type { ChatMessageInfoItemWithHeight } from '../types/chat-types.js';
	import { useShouldRenderAvatars } from '../utils/avatar-utils.js';			import { useShouldRenderAvatars } from '../utils/avatar-utils.js';

	type Props = {			type Props = {
	+item: ChatMessageInfoItemWithHeight,			+item: ChatMessageInfoItemWithHeight,
	+focused: boolean,			+focused: boolean,
	+display: DisplayType,			+display: DisplayType,
	};			};
	function MessageHeader(props: Props): React.Node {			function MessageHeader(props: Props): React.Node {
	const styles = useStyles(unboundStyles);			const styles = useStyles(unboundStyles);
	const { item, focused, display } = props;			const { item, focused, display } = props;
	const { creator, time } = item.messageInfo;			const { creator, time } = item.messageInfo;
	const { isViewer } = creator;			const { isViewer } = creator;
				const route = useRoute();
	const modalDisplay = display === 'modal';			const modalDisplay = display === 'modal';

	const shouldShowUsername = !isViewer && (modalDisplay \|\| item.startsCluster);			const shouldShowUsername = !isViewer && (modalDisplay \|\| item.startsCluster);
	const stringForUser = useStringForUser(shouldShowUsername ? creator : null);			const stringForUser = useStringForUser(shouldShowUsername ? creator : null);

	const shouldRenderAvatars = useShouldRenderAvatars();			const shouldRenderAvatars = useShouldRenderAvatars();

	let authorName = null;			let authorName = null;
	if (stringForUser) {			if (stringForUser) {
	const style = [styles.authorName];			const style = [styles.authorName];
	if (modalDisplay) {			if (modalDisplay) {
	style.push(styles.modal);			style.push(styles.modal);
	}			}

	if (shouldRenderAvatars) {			if (shouldRenderAvatars) {
	style.push({ marginLeft: 12 + avatarOffset });			style.push({ marginLeft: 12 + avatarOffset });
	} else {			} else {
	style.push({ marginLeft: 12 });			style.push({ marginLeft: 12 });
	}			}

	authorName = <SingleLine style={style}>{stringForUser}</SingleLine>;			authorName = <SingleLine style={style}>{stringForUser}</SingleLine>;
	}			}

				// We only want to render the top-placed timestamp for a message if it's
				// rendered in the message list, and not any separate screens (i.e.
				// the MessageResultsScreen).
				const presentedFromMessageList =
				typeof route.params?.presentedFrom === 'string' &&
				route.params.presentedFrom.startsWith(MessageListRouteName);

				const messageInMessageList =
				route.name === MessageListRouteName \|\| presentedFromMessageList;

	const timestamp =			const timestamp =
	modalDisplay \|\| item.startsConversation ? (			messageInMessageList && (modalDisplay \|\| item.startsConversation) ? (
	<Timestamp time={time} display={display} />			<Timestamp time={time} display={display} />
	) : null;			) : null;

	let style = null;			let style = null;
	if (focused && !modalDisplay) {			if (focused && !modalDisplay) {
	let topMargin = 0;			let topMargin = 0;
	if (!item.startsCluster && !item.messageInfo.creator.isViewer) {			if (!item.startsCluster && !item.messageInfo.creator.isViewer) {
	topMargin += authorNameHeight + clusterEndHeight;			topMargin += authorNameHeight + clusterEndHeight;
	Show All 34 Lines