This is the screen that should display the pinned messages / the search results.
Logic is similar to web: https://phab.comm.dev/D7380
Depends on D7672
Paths
| Differential D7673 Authored by rohan on Apr 27 2023, 11:15 AM.
Details Summary This is the screen that should display the pinned messages / the search results. Logic is similar to web: https://phab.comm.dev/D7380 Depends on D7672 Test Plan Check to see the pinned messages render in the screen
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptApr 27 2023, 11:15 AM2023-04-27 11:15:35 (UTC-7) rohan edited the test plan for this revision. (Show Details)Apr 27 2023, 11:19 AM2023-04-27 11:19:15 (UTC-7) rohan attached a referenced file: F513347: Simulator Screen Recording - iPhone 14 Pro - 2023-04-27 at 14.18.46.mp4. (Show Details)
Harbormaster completed remote builds in B18891: Diff 25877.Apr 27 2023, 11:32 AM2023-04-27 11:32:47 (UTC-7) rohan edited the summary of this revision. (Show Details)Apr 27 2023, 11:38 AM2023-04-27 11:38:59 (UTC-7)
Harbormaster completed remote builds in B19000: Diff 26020.May 2 2023, 1:32 PM2023-05-02 13:32:42 (UTC-7) Comment Actions
Is this ready for review at the moment? Sending back to your queue, feel free to re-request review if it is. This revision now requires changes to proceed.May 3 2023, 8:13 AM2023-05-03 08:13:37 (UTC-7)
Comment Actions
It's ready for review now, talked about it in my sync with Ashoat and it'll be best to leave it as is at the moment rohan edited the summary of this revision. (Show Details)May 5 2023, 4:30 PM2023-05-05 16:30:37 (UTC-7) rohan attached a referenced file: F524331: Simulator Screen Recording - iPhone 14 Pro - 2023-05-05 at 19.24.29.mp4. (Show Details) Harbormaster completed remote builds in B19089: Diff 26137.May 5 2023, 4:46 PM2023-05-05 16:46:35 (UTC-7) rohan edited the summary of this revision. (Show Details)May 5 2023, 5:32 PM2023-05-05 17:32:19 (UTC-7) ashoat added inline comments.
This revision now requires changes to proceed.May 6 2023, 1:57 AM2023-05-06 01:57:06 (UTC-7) ashoat attached a referenced file: F524570: Screenshot 2023-05-06 at 10.53.51 AM.png. (Show Details)May 6 2023, 4:49 AM2023-05-06 04:49:02 (UTC-7) Comment Actions Re-requesting review after D7736 and following up about whether we need messageListData or not:
This revision is now accepted and ready to land.May 8 2023, 7:17 AM2023-05-08 07:17:13 (UTC-7) Harbormaster completed remote builds in B19143: Diff 26213.May 8 2023, 10:53 AM2023-05-08 10:53:22 (UTC-7) Harbormaster completed remote builds in B19147: Diff 26217.May 8 2023, 12:00 PM2023-05-08 12:00:30 (UTC-7) Harbormaster completed remote builds in B19156: Diff 26227.May 8 2023, 12:30 PM2023-05-08 12:30:12 (UTC-7) Closed by commit rCOMMdb4d128b7604: [native] Display the pinned messages for the thread in the new screen (authored by RohanK6 <rohan.khanderia@gmail.com>, committed by rohan). · Explain WhyMay 8 2023, 12:38 PM2023-05-08 12:38:12 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26235 native/chat/message-result.react.js
native/chat/message-results-screen.react.js
native/chat/message.react.js
native/chat/robotext-message.react.js
native/chat/text-message.react.js
|