Page MenuHomePhabricator

[native] Extract onClose-disabling behavior from SIWEPanel to FullscreenSIWEPanel
ClosedPublic

Authored by ashoat on May 22 2023, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 9:42 PM
Unknown Object (File)
Tue, Mar 12, 4:43 PM
Unknown Object (File)
Feb 18 2024, 6:04 PM
Unknown Object (File)
Feb 18 2024, 4:43 PM
Unknown Object (File)
Feb 18 2024, 1:58 PM
Unknown Object (File)
Feb 18 2024, 1:42 PM
Unknown Object (File)
Feb 18 2024, 8:20 AM
Unknown Object (File)
Jan 10 2024, 9:40 PM
Subscribers

Details

Summary

In the original SIWEPanel, we implemented logic to make sure that after a successful SIWE, we didn't trigger goBackToPrompt after the closing of the bottom sheet.

However, this logic is currently messing with the new implementation, where it's preventing a second SIWE authorization since the first one was never cleared since the onClose wasn't called.

This diff moves the behavior that blocks goBackToPrompt to FullscreenSIWEPanel, so that both use cases work correctly.

Depends on D7927

Test Plan
  1. I tested the old workflow and made sure that goBackToPrompt wasn't triggered after a successful SIWE
  2. See videos below for the impact on the new workflow:
beforeafter

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage