[native] Show option to change role from the members list
ClosedPublic
Actions

Authored by rohan on Jun 9 2023, 11:19 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMMf81c6bbb7709: [native] Show option to change role from the members list

Summary

We need to show the option to allow admins to change roles from the members list

Depends on D8142

Test Plan

See below the screenshot that shows the option

Simulator Screen Shot - iPhone 14 Pro - 2023-06-09 at 14.20.02.png (2×1 px, 197 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jun 9 2023, 11:19 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 9 2023, 11:19 AM

rohan edited the test plan for this revision. (Show Details)Jun 9 2023, 11:20 AM

rohan attached a referenced file: F580138: Simulator Screen Shot - iPhone 14 Pro - 2023-06-09 at 14.20.02.png. (Show Details)

rohan added inline comments.

native/chat/settings/thread-settings-member-tooltip-modal.react.js
62–63	This is removed in one of the diffs right after this, and it won't be landed without the rest of the stack (inclusive of the code that replaces this)

rohan added a child revision: D8156: [native] Create a new screen that will show the role change information.Jun 9 2023, 11:23 AM

Harbormaster completed remote builds in B20134: Diff 27584.Jun 9 2023, 11:41 AM

rohan requested review of this revision.Jun 9 2023, 11:41 AM

Was removing "Remove admin" and "Make admin" options also intended to be a part of this diff? Didn't see anything in the title or summary so just want to make sure before this diff is accepted.

This revision now requires changes to proceed.Jun 12 2023, 12:54 PM

In D8155#241852, @atul wrote:

Was removing "Remove admin" and "Make admin" options also intended to be a part of this diff? Didn't see anything in the title or summary so just want to make sure before this diff is accepted.

Yeah it was meant to be part of this diff since I'm 'replacing' these options

atul accepted this revision.Jun 12 2023, 1:08 PM

This revision is now accepted and ready to land.Jun 12 2023, 1:08 PM

Rebase

This revision was landed with ongoing or failed builds.Jun 21 2023, 8:42 AM

Closed by commit rCOMMf81c6bbb7709: [native] Show option to change role from the members list (authored by rohan). · Explain Why

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMf81c6bbb7709: [native] Show option to change role from the members list.

Harbormaster completed remote builds in B20391: Diff 27945.Jun 21 2023, 9:07 AM

ashoat mentioned this in D10159: [lib] Get rid of switchMemberAdminRoleInThread.Dec 4 2023, 1:08 PM

ashoat mentioned this in rCOMM30126e729887: [lib] Get rid of switchMemberAdminRoleInThread.Dec 5 2023, 12:32 PM