Page MenuHomePhabricator

[web] Change how margins / paddings are used in message result
ClosedPublic

Authored by inka on Jun 14 2023, 6:20 AM.
Tags
None
Referenced Files
F4079050: D8207.id27993.diff
Sat, Feb 15, 3:57 PM
Unknown Object (File)
Thu, Feb 13, 10:15 AM
Unknown Object (File)
Thu, Feb 13, 10:15 AM
Unknown Object (File)
Sun, Feb 2, 1:38 AM
Unknown Object (File)
Jan 17 2025, 10:42 AM
Unknown Object (File)
Jan 17 2025, 10:28 AM
Unknown Object (File)
Jan 12 2025, 7:24 PM
Unknown Object (File)
Dec 30 2024, 7:28 PM
Subscribers

Details

Summary

I need to change how margins / paddings are used in message result, because I will be using this component with our SearchModal component that has some default margin. So I move the responsibility of setting the margins / paddings to the outer container.

Additionally the margin in TogglePinModal gets fixed: it seems to me from the designs that there should be a space between the message and the top text. @rohan please tell me if I'm misunderstanding

Test Plan

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka edited the test plan for this revision. (Show Details)
inka added 1 blocking reviewer(s): rohan.
inka requested review of this revision.Jun 14 2023, 6:49 AM

The code makes sense, but I can't actually see the screenshots since they seem to be restricted. Could you attach them please?

This revision is now accepted and ready to land.Jun 20 2023, 6:58 AM
inka edited the summary of this revision. (Show Details)

Rebase