Paths

Table of Contentst

Differential D8207

[web] Change how margins / paddings are used in message result
ClosedPublic
Actions

Authored by inka on Jun 14 2023, 6:20 AM.

Tags

None

Referenced Files

	F3242699: D8207.id.diff
	Thu, Nov 14, 2:18 AM

	Unknown Object (File)
	Wed, Nov 13, 2:23 AM

	Unknown Object (File)
	Sat, Nov 9, 11:59 PM

	Unknown Object (File)
	Sat, Nov 9, 4:19 AM

	Unknown Object (File)
	Fri, Nov 8, 6:38 AM

	Unknown Object (File)
	Fri, Nov 1, 8:11 AM

	Unknown Object (File)
	Fri, Nov 1, 5:34 AM

	Unknown Object (File)
	Wed, Oct 30, 7:21 AM

View All 95 Files

Subscribers

Details

Reviewers

Commits

rCOMM52d4e6c1be59: [web] Change how margins / paddings are used in message result

Summary

I need to change how margins / paddings are used in message result, because I will be using this component with our SearchModal component that has some default margin. So I move the responsibility of setting the margins / paddings to the outer container.

Additionally the margin in TogglePinModal gets fixed: it seems to me from the designs that there should be a space between the message and the top text. @rohan please tell me if I'm misunderstanding

Test Plan

Before:

After:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 14 2023, 6:20 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 14 2023, 6:20 AM

inka edited the summary of this revision. (Show Details)Jun 14 2023, 6:24 AM

inka edited the test plan for this revision. (Show Details)

inka added 1 blocking reviewer(s): rohan.

Harbormaster completed remote builds in B20246: Diff 27738.Jun 14 2023, 6:49 AM

inka requested review of this revision.Jun 14 2023, 6:49 AM

The code makes sense, but I can't actually see the screenshots since they seem to be restricted. Could you attach them please?

@rohan sorry, it should be fine now

inka added a child revision: D8240: [web] Add message search modal.Jun 16 2023, 7:17 AM

rohan accepted this revision.Jun 20 2023, 6:58 AM

This revision is now accepted and ready to land.Jun 20 2023, 6:58 AM

Rebase

Harbormaster failed remote builds in B20419: Diff 27993!Jun 22 2023, 7:34 AM

Harbormaster completed remote builds in B20419: Diff 27993.Jun 26 2023, 6:33 AM

Closed by commit rCOMM52d4e6c1be59: [web] Change how margins / paddings are used in message result (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:25 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM52d4e6c1be59: [web] Change how margins / paddings are used in message result.

Revision Contents
Changeset List

Path

Size

web/

components/

message-result.css

1 line

modals/

chat/

message-results-modal.css

6 lines

toggle-pin-modal.css

4 lines

toggle-pin-modal.react.js

12 lines

Diff 28151

web/components/message-result.css

Loading...

web/modals/chat/message-results-modal.css

Loading...

web/modals/chat/toggle-pin-modal.css

Loading...

web/modals/chat/toggle-pin-modal.react.js

Loading...