Page MenuHomePhabricator

[web] Introduce onClearText to Search
ClosedPublic

Authored by inka on Jun 21 2023, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 1:45 PM
Unknown Object (File)
Sat, Nov 23, 1:45 PM
Unknown Object (File)
Sat, Nov 23, 1:09 PM
Unknown Object (File)
Sat, Nov 23, 1:09 PM
Unknown Object (File)
Sat, Nov 9, 4:04 AM
Unknown Object (File)
Fri, Nov 8, 9:59 PM
Unknown Object (File)
Fri, Nov 1, 8:17 AM
Unknown Object (File)
Fri, Nov 1, 5:34 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3466/add-some-state-for-keeping-the-search-query
In message search when a user clears the query we will need to remove the query from context. For this I need to ba able to pass a callback to the Search component. The flex: 1 was added because in
message search modal we want to have a button next to it, and have the two of them take up the full width of the modal.

Test Plan

Tested that a provided callback is called on clear

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Jun 21 2023, 5:34 AM
inka retitled this revision from [web] Intirduce onClearText to Search to [web] Introduce onClearText to Search.
This revision is now accepted and ready to land.Jun 23 2023, 2:06 AM