[web] Extract useParseSearchResults
ClosedPublic
Actions

Authored by inka on Jun 22 2023, 7:16 AM.

Details

Reviewers

kamil
• kuba
michal

Commits

rCOMM5dfc71e8bc94: [web] Extract useParseSearchResults

Summary

issue: https://linear.app/comm/issue/ENG-3462/add-modal-for-searching-messages
This diff is only refactoring

Test Plan

Checked that message search modal still works

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jun 22 2023, 7:16 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 7:16 AM

inka added a parent revision: D8275: [web] Make pressing enter initiate search.Jun 22 2023, 7:16 AM

inka added a child revision: D8291: [web] Inline MessageSearchModalContent.Jun 22 2023, 7:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 7:29 AM

Harbormaster failed remote builds in B20421: Diff 27995!

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 8:15 AM

Harbormaster failed remote builds in B20429: Diff 28003!

inka requested review of this revision.Jun 23 2023, 1:16 AM

michal accepted this revision.Jun 23 2023, 2:35 AM

This revision is now accepted and ready to land.Jun 23 2023, 2:35 AM

Harbormaster completed remote builds in B20429: Diff 28003.Jun 26 2023, 7:38 AM

Closed by commit rCOMM5dfc71e8bc94: [web] Extract useParseSearchResults (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:26 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM5dfc71e8bc94: [web] Extract useParseSearchResults.

Revision Contents
Changeset List

Path

Size

web/

modals/

search/

message-search-modal.react.js

60 lines

message-search-utils.react.js

70 lines

Diff 28158

View Options

web/modals/search/message-search-modal.react.js