Page MenuHomePhabricator
Differential D8302

[web] Add message search button
ClosedPublic
Actions

Authored by inka on Jun 23 2023, 2:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:04 AM
Unknown Object (File)
Fri, Nov 1, 8:17 AM
Unknown Object (File)
Fri, Nov 1, 5:33 AM
Unknown Object (File)
Oct 2 2024, 9:25 AM
Unknown Object (File)
Oct 2 2024, 9:25 AM
Unknown Object (File)
Oct 2 2024, 9:25 AM
Unknown Object (File)
Oct 2 2024, 9:19 AM
Unknown Object (File)
Oct 2 2024, 3:47 AM
View All Files
Subscribers
ashoat
• ted
tomek

Details

Reviewers
kamil
• kuba
michal
Commits
rCOMM6fc36ae5cdde: [web] Add message search button
Summary

issue: https://linear.app/comm/issue/ENG-3461/add-magnifying-glass-button-to-chat-header

Test Plan

(showing for the record that the pinned messages banner is not bound to message search)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jun 23 2023, 2:03 AM
Herald added subscribers: • ted, tomek, ashoat. · View Herald TranscriptJun 23 2023, 2:03 AM
inka added a parent revision: D8301: [web] Remember resutls in search modal.Jun 23 2023, 2:03 AM
inka edited the test plan for this revision. (Show Details)
inka attached a referenced file: F603357: Screen Recording 2023-06-23 at 10.57.34.mov. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 2:26 AM
Harbormaster failed remote builds in B20449: Diff 28031!
inka requested review of this revision.Jun 23 2023, 2:43 AM
michal accepted this revision.Jun 23 2023, 5:30 AM
This revision is now accepted and ready to land.Jun 23 2023, 5:30 AM
inka added inline comments.Jun 23 2023, 5:48 AM
web/chat/thread-top-bar.css
27–32 ↗(On Diff #28031)

This wasn't being used anywhere

web/theme.css
114 ↗(On Diff #28031)

This was only used in the css I delete in this diff

inka updated this revision to Diff 28046.Jun 23 2023, 5:50 AM

Inline search button

Harbormaster failed remote builds in B20464: Diff 28046!Jun 23 2023, 6:12 AM
Harbormaster completed remote builds in B20464: Diff 28046.Jun 26 2023, 7:38 AM
inka edited parent revisions, added: D8291: [web] Inline MessageSearchModalContent; removed: D8301: [web] Remember resutls in search modal.Jun 27 2023, 4:21 AM
inka added a child revision: D8293: [web] Add to MessageSearchContext results related information.Jun 27 2023, 4:25 AM
Closed by commit rCOMM6fc36ae5cdde: [web] Add message search button (authored by • InkaSokolowska). · Explain WhyJun 27 2023, 4:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM6fc36ae5cdde: [web] Add message search button.

Revision Contents
Changeset List

PathSize
web/
chat/
17 lines
24 lines
2 lines

Diff 28160

View Options

web/chat/thread-top-bar.css

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/theme.css

Loading...