Page MenuHomePhabricator

[web] Inline MessageSearchModalContent
ClosedPublic

Authored by inka on Jun 22 2023, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 1:58 PM
Unknown Object (File)
Sat, Nov 23, 1:58 PM
Unknown Object (File)
Sat, Nov 23, 1:58 PM
Unknown Object (File)
Sat, Nov 23, 1:58 PM
Unknown Object (File)
Sat, Nov 23, 1:57 PM
Unknown Object (File)
Sat, Nov 23, 1:12 PM
Unknown Object (File)
Sat, Nov 23, 1:12 PM
Unknown Object (File)
Fri, Nov 8, 6:01 AM
Subscribers

Details

Summary

After D8274 MessageSearchModalContent can be inlined. This is also needed for later diffs, where this separation was making the code unnecessarily complex
issue: https://linear.app/comm/issue/ENG-3462/add-modal-for-searching-messages

Test Plan

Checked that message search modal still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka edited the summary of this revision. (Show Details)
inka edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 7:33 AM
Harbormaster failed remote builds in B20422: Diff 27996!
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 22 2023, 8:16 AM
Harbormaster failed remote builds in B20430: Diff 28004!
inka requested review of this revision.Jun 23 2023, 1:17 AM
michal added inline comments.
web/modals/search/message-search-modal.react.js
176 ↗(On Diff #28004)
This revision is now accepted and ready to land.Jun 23 2023, 3:40 AM