Page MenuHomePhabricator
Differential D8299

[keyserver] improve error messages in rust-node-addon
ClosedPublic
Actions

Authored by varun on Jun 22 2023, 11:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 2, 8:51 PM
Unknown Object (File)
Tue, Feb 25, 12:57 PM
Unknown Object (File)
Mon, Feb 24, 8:33 PM
Unknown Object (File)
Sun, Feb 23, 6:11 PM
Unknown Object (File)
Feb 18 2025, 5:07 PM
Unknown Object (File)
Feb 13 2025, 4:02 PM
Unknown Object (File)
Feb 11 2025, 1:58 PM
Unknown Object (File)
Feb 11 2025, 1:57 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon
Summary

add a more detailed message in case an error is caught.

Depends on D8298

Test Plan

ran keyserver but not identity service to get errors connecting to identity. saw better error logs

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jun 22 2023, 11:45 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 22 2023, 11:45 PM
varun added a child revision: D8300: [keyserver] call identity service during account creation and deletion.Jun 22 2023, 11:46 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 12:07 AM
Harbormaster failed remote builds in B20445: Diff 28027!
varun requested review of this revision.Jun 23 2023, 1:22 PM
• jon accepted this revision.Jun 26 2023, 5:54 AM
This revision is now accepted and ready to land.Jun 26 2023, 5:54 AM
This revision was landed with ongoing or failed builds.Jun 26 2023, 6:54 PM
Closed by commit rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon (authored by varun). · Explain Why
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
2 lines
2 lines

Diff 28027

View Options

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_username.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines
View Options

keyserver/addons/rust-node-addon/src/identity_client/remove_reserved_username.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
### Workflow specific prerequisites ### Workflow specific prerequisites
On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows. On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for all workflows.
- [Web prerequisites](./nix_web_setup.md#nix-web-requisities) - [Web prerequisites](./nix_web_setup.md#nix-web-requisities)
- [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension) - [React Dev Tools Chrome extension](./nix_web_setup.md#react-dev-tools-chrome-extension)
- [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension) - [Redux Dev Tools Chrome extension](./nix_web_setup.md#redux-dev-tools-chrome-extension)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites) - [Mobile prerequisites](./nix_mobile_setup.md#nix-mobile-prerequisites)
- [iOS development](./nix_mobile_setup.md#ios-development) - [iOS development](./nix_mobile_setup.md#ios-development)
- [Xcode](./nix_mobile_setup.md#xcode) - [Xcode](./nix_mobile_setup.md#xcode)
- [Xcode settings](./nix_mobile_setup.md#xcode-settings) - [Xcode settings](./nix_mobile_setup.md#xcode-settings)
- [Android development](./nix_mobile_setup.md#android-development) - [Android development](./nix_mobile_setup.md#android-development)
- [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk) - [JDK (Java Development Kit)](./nix_mobile_setup.md#jdk)
- [Android Studio](./nix_mobile_setup.md#android-studio) - [Android Studio](./nix_mobile_setup.md#android-studio)
- [Android SDK](./nix_mobile_setup.md#android-sdk) - [Android SDK](./nix_mobile_setup.md#android-sdk)
- [Android emulator](./nix_mobile_setup.md#android-emulator) - [Android emulator](./nix_mobile_setup.md#android-emulator)
- [Debugging tools](./nix_mobile_setup.md#debugging-tools) - [Debugging tools](./nix_mobile_setup.md#debugging-tools)
- [Homebrew](./nix_mobile_setup.md#homebrew) - [Homebrew](./nix_mobile_setup.md#homebrew)
- [Reactotron](./nix_mobile_setup.md#reactotron) - [Reactotron](./nix_mobile_setup.md#reactotron)
- [Flipper (React Native Debugger)](./nix_mobile_setup.md#flipper)
- [idb (iOS Development Bridge)](./nix_mobile_setup.md#idb)
# Development environment # Development environment
Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites). Run `nix develop` to create a dev environment. Nix will handle the installation of all remaining dependencies not mentioned in [Workflow prerequisites](#workflow-prerequisites).
## Development workflows ## Development workflows
- [Web workflows](./nix_web_workflows.md#development) - [Web workflows](./nix_web_workflows.md#development)
Show All 27 Lines