[keyserver] improve error messages in rust-node-addon
ClosedPublic
Actions

Authored by varun on Jun 23 2023, 6:45 AM.

Details

Reviewers

• jon
bartek

Commits

rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon

Summary

add a more detailed message in case an error is caught.

Depends on D8298

Test Plan

ran keyserver but not identity service to get errors connecting to identity. saw better error logs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 23 2023, 6:45 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 23 2023, 6:45 AM

varun added a child revision: D8300: [keyserver] call identity service during account creation and deletion.Jun 23 2023, 6:46 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 23 2023, 7:07 AM

Harbormaster failed remote builds in B20445: Diff 28027!

varun requested review of this revision.Jun 23 2023, 8:22 PM

• jon accepted this revision.Jun 26 2023, 12:54 PM

This revision is now accepted and ready to land.Jun 26 2023, 12:54 PM

This revision was landed with ongoing or failed builds.Jun 27 2023, 1:54 AM

Closed by commit rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon. · Explain Why

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM8e11f2df18b3: [keyserver] improve error messages in rust-node-addon.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

add_reserved_username.rs

2 lines

remove_reserved_username.rs

2 lines

Diff 28128

View Options

keyserver/addons/rust-node-addon/src/identity_client/add_reserved_username.rs